Skip to content

IPv6 MLD updates

Daniel Borkmann netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 2 repliesIn review
  2. v18 patches 10 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net: ipv6: mld: fix v1/v2 switchback timeout to rfc3810, 9.12.include/net/if_inet6.h include/net/mld.h net/ipv6/mcast.c+143 -90 replies
2/8net: ipv6: mld: clean up MLD_V1_SEEN macronet/ipv6/mcast.c+21 -130 replies
3/8net: ipv6: mld: get rid of MLDV2_MRC and simplify calculationinclude/net/mld.h net/bridge/br_multicast.c net/ipv6/mcast.c+23 -260 replies
4/8net: ipv6: mld: implement RFC3810 MLDv2 mode onlynet/ipv6/mcast.c+30 -41 reply
5/8net: ipv6: mld: similarly to MLDv2 have min max_delay of 1net/ipv6/mcast.c+7 -70 replies
6/8net: ipv6: mld: refactor query processing into v1/v2 functionsnet/ipv6/mcast.c+56 -330 replies
7/8net: ipv6: mld: introduce mld_{gq,ifc,dad}_stop_timer functionsnet/ipv6/mcast.c+25 -160 replies
8/8net: ipv6: mld: document force_mld_version in ip-sysctl.txtDocumentation/networking/ip-sysctl.txt+5 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchHannes Frederic Sowa
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/8] IPv6 MLD updates

This set contains the non-RFC version of the previous submission entitled "[RFC PATCH net-next 0/7] IPv6 MLD updates". Most importantly it contains a fix for MLDv1/v2 switchback timeout where hosts currently are switching back from v1 compat mode to normal v2 too early (i.e. switchback time was <= 30secs instead of >= 260secs on default), and the set also contains a patch that allows for v2-only mode as per RFC recommendation. The rest is related to cleanups that make the code more readable resp. maintainable.

Changes from RFC to non-RFC:

We ignore v2 messages now when in v1 compat mode, otherwise report timers are reset and triggered, also stop current v2 report timer in case it is currently running and we received a v1 query; use WARN_ON instead of BUG_ON for RV of 0 (patch1).

Two more patches have been added that makes to code more readable, that is "net: ipv6: mld: refactor query processing into v1/v2 functions" and "net: ipv6: mld: introduce mld_{gq,ifc,dad}_stop_timer functions", the sysctl patch "net: ipv6: mld: restrict min/max of sysctl force_mld_version" has been dropped as extra1 and extra2 vars are overwritten with idev and net anyway when addrconf sysctl is registered, hence dropped for now. The rest is unchanged, only adapted to take changes into account.

Changes from v1 to v2:

Minor update in "net: ipv6: mld: implement RFC3810 MLDv2 mode only" in MLD version selection. Rest stays the same, added Acked-bys from Hannes in unchanged patches.

Thanks!

Daniel Borkmann (8):
net: ipv6: mld: fix v1/v2 switchback timeout to rfc3810, 9.12.
net: ipv6: mld: clean up MLD_V1_SEEN macro
net: ipv6: mld: get rid of MLDV2_MRC and simplify calculation
net: ipv6: mld: implement RFC3810 MLDv2 mode only
net: ipv6: mld: similarly to MLDv2 have min max_delay of 1
net: ipv6: mld: refactor query processing into v1/v2 functions
net: ipv6: mld: introduce mld_{gq,ifc,dad}_stop_timer functions
net: ipv6: mld: document force_mld_version in ip-sysctl.txt

 Documentation/networking/ip-sysctl.txt |   5 +
 include/net/if_inet6.h                 |   9 +-
 include/net/mld.h                      |  51 +++++--
 net/bridge/br_multicast.c              |   3 +-
 net/ipv6/mcast.c                       | 248 +++++++++++++++++++++++++++------
 5 files changed, 259 insertions(+), 57 deletions(-)
Signature · 1 line
1.7.11.7