Skip to content

RFC xfs: introduce the free inode btree

Brian Foster linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest11 patches 34 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11xfs: refactor xfs_ialloc_btree.c to support multiple inobt numbersfs/xfs/xfs_ialloc.c fs/xfs/xfs_ialloc_btree.c fs/xfs/xfs_ialloc_btree.h +1 more+15 -101 reply
2/11xfs: reserve v5 superblock read-only compat. feature bit for finobtfs/xfs/xfs_sb.h+9 -11 reply
3/11xfs: support the XFS_BTNUM_FINOBT free inode btree typefs/xfs/xfs_ag.h fs/xfs/xfs_btree.c fs/xfs/xfs_btree.h +6 more+71 -125 replies
4/11xfs: update inode allocation transaction reservations for finobtfs/xfs/xfs_trans_resv.c fs/xfs/xfs_trans_space.h+9 -23 replies
5/11xfs: update ifree transaction reservations for finobtfs/xfs/xfs_trans_resv.c fs/xfs/xfs_trans_space.h+6 -11 reply
6/11xfs: use correct transaction reservations in xfs_inactive()fs/xfs/xfs_inode.c+37 -342 replies
7/11xfs: retry trans reservation on ENOSPC in xfs_inactive()fs/xfs/xfs_inode.c+11 -04 replies
8/11xfs: insert newly allocated inode chunks into the finobtfs/xfs/xfs_ialloc.c+56 -231 reply
9/11xfs: use and update the finobt on inode allocationfs/xfs/xfs_ialloc.c+135 -12 replies
10/11xfs: update the finobt on inode freefs/xfs/xfs_ialloc.c+120 -08 replies
11/11xfs: add finobt support to growfsfs/xfs/xfs_fsops.c+32 -01 reply

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchDave Chinner
1/11R-b
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/11] xfs: introduce the free inode btree

Hi all,

This is an RFC for the kernel work to support a free inode btree. The free inode btree (finobt) is equivalent to the existing inode allocation btree with the exception that the finobt only tracks inode chunks with at least one free inode. The purpose is to improve lookups for free inode clusters for inode allocation.

Newly allocated inode chunks by definition contain free inodes and are thus inserted into the finobt immediately. The record for a previously full inode chunk is inserted to the finobt when the first inode is freed. A record is removed from the finobt when the last free inode has been allocated or the entire chunk is completely deallocated.

Patches 1-3 refactor some ialloc btree code to introduce the new finobt type and feature bit. Patches 4-7 fix up the transaction handling for inode allocation and deallocation to account for the new tree. Patches 8-10 add the finobt management code to insert, remove and modify records as appropriate. Patch 11 fixes growfs to support the finobt.

Thoughts, reviews, flames appreciated.

NOTES:
- This is RFC because it is lightly tested and I don't have much userspace code at the moment (though most of this code should apply).
- I'm not totally sure about the scope of change in patch 6 (use correct transaction reservations in xfs_inactive()). I started off minimally altering the reserved blocks value, but the existing transaction management seemed strange enough that I ended up with the current patch. I figured I'd start here and pare it back as necessary if the changes are bogus or lead to other problems.
- I've yet to do any performance testing to measure the benefit of patch 9.

Brian

Brian Foster (11):
xfs: refactor xfs_ialloc_btree.c to support multiple inobt numbers
xfs: reserve v5 superblock read-only compat. feature bit for finobt
xfs: support the XFS_BTNUM_FINOBT free inode btree type
xfs: update inode allocation transaction reservations for finobt
xfs: update ifree transaction reservations for finobt
xfs: use correct transaction reservations in xfs_inactive()
xfs: retry trans reservation on ENOSPC in xfs_inactive()
xfs: insert newly allocated inode chunks into the finobt
xfs: use and update the finobt on inode allocation
xfs: update the finobt on inode free
xfs: add finobt support to growfs

 fs/xfs/xfs_ag.h           |   7 +-
 fs/xfs/xfs_btree.c        |   6 +-
 fs/xfs/xfs_btree.h        |   3 +
 fs/xfs/xfs_fsops.c        |  32 +++++
 fs/xfs/xfs_ialloc.c       | 343 ++++++++++++++++++++++++++++++++++++++++++----
 fs/xfs/xfs_ialloc_btree.c |  37 +++--
 fs/xfs/xfs_ialloc_btree.h |  17 ++-
 fs/xfs/xfs_inode.c        |  82 ++++++-----
 fs/xfs/xfs_itable.c       |   6 +-
 fs/xfs/xfs_log_recover.c  |   2 +
 fs/xfs/xfs_sb.h           |  10 +-
 fs/xfs/xfs_stats.h        |  18 ++-
 fs/xfs/xfs_trans_resv.c   |  14 +-
 fs/xfs/xfs_trans_space.h  |   4 +-
 fs/xfs/xfs_types.h        |   2 +-
 15 files changed, 500 insertions(+), 83 deletions(-)
Signature · 6 lines
1.8.1.4

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs