Skip to content

RFC use sizes.h macros for power-of-two sizes

Antony Pavlov qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest2 patches 4 repliesIn review
  2. v2 RFC2 patches 1 replySuperseded
  3. v1 RFC2 patches 5 repliesSuperseded

Changes in v3 from the cover letter

* commit messages: drop ALL 'Reviewed-by' tags. Drop Aurelien Jarno's tag because the patchseries was completely reworked, so it need additional review.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2include/qemu: introduce sizes.hinclude/qemu/sizes.h+61 -00 replies
2/2hw/mips: use sizes.h macroshw/mips/mips_malta.c include/hw/mips/bios.h+15 -130 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard Henderson
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes

Changes since v2:
* commit messages: drop ALL 'Reviewed-by' tags. Drop Aurelien Jarno's tag because the patchseries was completely reworked, so it need additional review.

Changes since v1:

* include/sizes.h -> include/qemu/sizes.h
* fix copyright header;
* fix formatting: drop tabs;
* use the BIT() macro, so it's easy-to-read the constants column; also the BIT() macro casts constant to UL;
* rebase on updated master;
* take into account the "mips_malta: support up to 2GiB RAM" commit.

[RFC v3 1/2] include/qemu: introduce sizes.h [RFC v3 2/2] hw/mips: use sizes.h macros

The sizes.h macros is a easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in linux kernel and other projects, so let's use them in QEMU too.