pci: keep window properties up to date
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest6 patches 2 repliesIn review
- v16 patches 16 repliesSuperseded
Changes in v2 from the cover letter
Fix up issues noted by Igor:
- ignore addresses below 1<<32 when getting W64
- don't change W64 - instead calculate it in a local variable. This way users are forced to use the property API so they won't get an out of date range by accessing w64 directly.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | q35: make pci window address/size match guest cfghw/ | +10 | 0 replies | |
| 2/6 | range: add Range to typedefsinclude/ include/ | +2 | 0 replies | |
| 3/6 | range: add min/max operations on rangesinclude/ | +17 | 1 reply | |
| 4/6 | pci: add helper to retrieve the 64-bit rangehw/ include/ | +51 | 0 replies | |
| 5/6 | q35: use 64 bit window programmed by guesthw/ | +10 | 0 replies | |
| 6/6 | piix: use 64 bit window programmed by guesthw/ | +10 | 0 replies |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Igor Mammedov |
|---|---|
| Series | A-b |
| 1/6 | |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/6] pci: keep window properties up to date
w32/w64 properties that we report in QOM are currently static, but this is wrong:
guest firmware can select its own windows:
optimal placement for w64 is guest-dependent, further, for Q35, w32 is affected by the MCFG base and size.
This detects the actual window configuration used by guest and reports it in QOM.
Changes from v1:
Fix up issues noted by Igor:
- ignore addresses below 1<<32 when getting W64
- don't change W64 - instead calculate it in a local variable. This way users are forced to use the property API so they won't get an out of date range by accessing w64 directly.
Note: maybe we should get rid of the pci_info struct completely, it doesn't seem to be all that useful anymore.
However, this is better addressed by a separate patch.
Michael S. Tsirkin (6):
q35: make pci window address/size match guest cfg
range: add Range to typedefs
range: add min/max operations on ranges
pci: add helper to retrieve the 64-bit range
q35: use 64 bit window programmed by guest
piix: use 64 bit window programmed by guest
include/hw/pci/pci.h | 1 + include/qemu/range.h | 19 ++++++++++++++++++- include/qemu/typedefs.h | 1 + hw/pci-host/piix.c | 14 ++++++++++---- hw/pci-host/q35.c | 24 ++++++++++++++++++++---- hw/pci/pci.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 100 insertions(+), 9 deletions(-)
Signature · 1 line
MST