Skip to content

Fixes for various minor Coverity issues

Matthew Daley xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8x86: add missing va_end to hypercall_xlat_continuationxen/arch/x86/domain.c+4 -02 replies
2/8sched/arinc653: check for guest data transfer failuresxen/common/sched_arinc653.c+11 -25 replies
3/8libxl: fix use-after-free in discard_events iterationtools/libxl/libxl.c+2 -21 reply
4/8libxl: correctly handle readlink() errorstools/libxl/libxl_exec.c+1 -11 reply
5/8mini-os: fix use-after-free in xs_daemon_close event iterationextras/mini-os/lib/xs.c+5 -21 reply
6/8mini-os: handle possibly overlong _nodename in init_consfrontextras/mini-os/console/xenbus.c+4 -21 reply
7/8kdd: fix free of array-typed valuetools/debugger/kdd/kdd-xen.c+0 -12 replies
8/8xenstored: fix possible, but unlikely, stack overflowtools/xenstore/xenstored_linux.c+1 -12 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchSamuel ThibaultAndrew CooperTim DeeganIan JacksonGeorge DunlapKeir FraserKathy Hadley
1/8R-b A-b
2/8R-b A-b A-b A-b A-b
3/8A-b
4/8A-b
5/8A-b
6/8A-b
7/8R-b A-b
8/8R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] Fixes for various minor Coverity issues

These are fixes for various minor non-security-impacting issues discovered by Coverity. They have been build-tested, but not runtime-tested; they are hopefully all obvious fixes.

Matthew Daley (8):
x86: add missing va_end to hypercall_xlat_continuation sched/arinc653: check for guest data transfer failures
libxl: fix use-after-free in discard_events iteration
libxl: correctly handle readlink() errors
mini-os: fix use-after-free in xs_daemon_close event iteration
mini-os: handle possibly overlong _nodename in init_consfront
kdd: fix free of array-typed value
xenstored: fix possible, but unlikely, stack overflow

 extras/mini-os/console/xenbus.c  |    6 ++++--
 extras/mini-os/lib/xs.c          |    7 +++++--
 tools/debugger/kdd/kdd-xen.c     |    1 -
 tools/libxl/libxl.c              |    4 ++--
 tools/libxl/libxl_exec.c         |    2 +-
 tools/xenstore/xenstored_linux.c |    2 +-
 xen/arch/x86/domain.c            |    4 ++++
 xen/common/sched_arinc653.c      |   13 +++++++++++--
 8 files changed, 28 insertions(+), 11 deletions(-)
Signature · 1 line
1.7.10.4