Skip to content

NFSv4.1: sp4_mach_cred cleanup (v2)

Weston Andros Adamson linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4NFSv4.1: sp4_mach_cred: ask for WRITE and COMMITfs/nfs/nfs4proc.c+4 -20 replies
2/4NFSv4.1: fix SECINFO* use of put_rpccredfs/nfs/nfs4proc.c+10 -60 replies
3/4NFSv4.1: sp4_mach_cred: no need to ref count credsfs/nfs/nfs4_fs.h+3 -33 replies
4/4NFSv4.1: sp4_mach_cred: WARN_ON -> WARN_ON_ONCEfs/nfs/nfs4_fs.h+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] NFSv4.1: sp4_mach_cred cleanup (v2)

Version 2 takes a new approach that Trond requested: we rely on the cl_machine_cred to have a reference held for the life of the nfs_client structure, so the sp4 stuff doesn't need to do any get/put_rpccred.

There's also two new patches:
- "fix SECINFO* use of put_rpccred" - recent changes (by me!) called put_rpccred of rpc_message.rpc_cred, but this value can change when nfs4_state_protect() is called. I searched through the rest of the client source and couldn't find another place where this happens.

- WARN_ON -> WARN_ON_ONCE - oops.

Weston Andros Adamson (4):
NFSv4.1: sp4_mach_cred: ask for WRITE and COMMIT NFSv4.1: fix SECINFO* use of put_rpccred NFSv4.1: sp4_mach_cred: no need to ref count creds NFSv4.1: sp4_mach_cred: WARN_ON -> WARN_ON_ONCE

 fs/nfs/nfs4_fs.h  | 10 +++++-----
 fs/nfs/nfs4proc.c | 22 ++++++++++++++--------
 2 files changed, 19 insertions(+), 13 deletions(-)
Signature · 1 line
1.7.12.4 (Apple Git-37)