Skip to content

perf tools: Enhance and correct srcline behavior (v2)

Namhyung Kim lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9perf sort: Fix a memory leak on srclinetools/perf/util/sort.c+1 -40 replies
2/9perf annotate: Reuse path from the result of addr2linetools/perf/util/annotate.c+1 -50 replies
3/9perf hists: Free srcline when freeing hist_entrytools/perf/util/hist.c+1 -00 replies
4/9perf tools: Factor out get/free_srcline()tools/perf/Makefile tools/perf/util/annotate.c tools/perf/util/hist.c +3 more+97 -320 replies
5/9perf tools: Do not try to call addr2line for non-binary filestools/perf/util/sort.c tools/perf/util/srcline.c+9 -50 replies
6/9perf tools: Pass dso instead of dso_name to get_srcline()tools/perf/util/annotate.c tools/perf/util/dso.h tools/perf/util/sort.c +2 more+12 -100 replies
7/9perf tools: Save failed result of get_srcline()tools/perf/util/dso.c tools/perf/util/dso.h tools/perf/util/srcline.c+10 -20 replies
8/9perf tools: Implement addr2line directly using libbfdtools/perf/config/Makefile tools/perf/util/srcline.c+171 -00 replies
9/9perf tools: Fix srcline sort key behaviortools/perf/util/sort.c+20 -210 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchJiri Olsa
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/9] perf tools: Enhance and correct srcline behavior (v2)

Hello,

This patchset tries to fix and enhance current srcline behavior.

Firstly it doesn't actually sort by srcline info but by ip. I suspect it was because of a performance reason to run external addr2line utility. It showed the srcline info after hist entries were collapsed. Thanks to Roberto, we now have internal implementation of addr2line using libbfd so can sort/compare by srcline of entries.

Second problem for me was it sometimes printed "??:0" and sometimes printed a raw ip value for unknown srcline info. I changed to print the former consistently.

While at it, I found some bugs/leaks in srcline handling. Patch 1-3 are fixes for those and can be merged separately.

* v2 changes
- add reviewed-by tags from Jiri
- rebased on top of current acme/perf/core

You can get this series on my 'perf/srcline-v2' branch in my tree at:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks.
Namhyung

Namhyung Kim (8):
perf sort: Fix a memory leak on srcline
perf annotate: Reuse path from the result of addr2line perf hists: Free srcline when freeing hist_entry perf tools: Factor out get/free_srcline()
perf tools: Do not try to call addr2line for non-binary files perf tools: Pass dso instead of dso_name to get_srcline() perf tools: Save failed result of get_srcline() perf tools: Fix srcline sort key behavior

Roberto Vitillo (1):
perf tools: Implement addr2line directly using libbfd

 tools/perf/Makefile        |   1 +
 tools/perf/config/Makefile |   4 +
 tools/perf/util/annotate.c |  33 +-----
 tools/perf/util/dso.c      |   1 +
 tools/perf/util/dso.h      |   2 +
 tools/perf/util/hist.c     |   1 +
 tools/perf/util/sort.c     |  58 ++++------
 tools/perf/util/srcline.c  | 265 +++++++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/util.h     |   8 ++
 9 files changed, 308 insertions(+), 65 deletions(-)
 create mode 100644 tools/perf/util/srcline.c
Signature · 1 line
1.7.11.7