Skip to content

Bluetooth: Various L2CAP fixes

[email protected] linux-bluetooth 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 5 repliesIn review
  2. v48 patches 4 repliesSuperseded
  3. v38 patches 13 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches0 repliesSuperseded
v13 patches8 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Bluetooth: Remove unused event mask structinclude/net/bluetooth/hci.h+0 -30 replies
2/8Bluetooth: Fix double error response for l2cap_create_chan_reqnet/bluetooth/l2cap_core.c+1 -10 replies
3/8Bluetooth: Fix L2CAP error return used for failed channel lookupsnet/bluetooth/l2cap_core.c+4 -41 reply
4/8Bluetooth: Fix L2CAP Disconnect response for unknown CIDnet/bluetooth/l2cap_core.c+1 -11 reply
5/8Bluetooth: Fix L2CAP command reject reasonnet/bluetooth/l2cap_core.c+16 -41 reply
6/8Bluetooth: Fix sending responses to identified L2CAP response packetsnet/bluetooth/l2cap_core.c+6 -60 replies
7/8Bluetooth: Fix responding to invalid L2CAP signaling commandsnet/bluetooth/l2cap_core.c+8 -00 replies
8/8Bluetooth: Fix waiting for clearing of BT_SK_SUSPEND flaginclude/net/bluetooth/bluetooth.h net/bluetooth/af_bluetooth.c net/bluetooth/l2cap_sock.c +1 more+53 -12 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMarcel Holtmann
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/8] Bluetooth: Various L2CAP fixes

Hi,

Here's a fifth revision with all feedback taken into account (as far as these 8 patches are concerned). There's still the issue of verifying sk locking in l2cap_sock_sendmsg as well as a potentially missing comment for the wait_state function, but even if those fixes are needed they'll end up being in separate patches. So, I'm hoping this patch set could start reaching its conclusion.

Johan

----------------------------------------------------------------
Johan Hedberg (8):
Bluetooth: Remove unused event mask struct
Bluetooth: Fix double error response for l2cap_create_chan_req
Bluetooth: Fix L2CAP error return used for failed channel lookups
Bluetooth: Fix L2CAP Disconnect response for unknown CID
Bluetooth: Fix L2CAP command reject reason
Bluetooth: Fix sending responses to identified L2CAP response packets
Bluetooth: Fix responding to invalid L2CAP signaling commands
Bluetooth: Fix waiting for clearing of BT_SK_SUSPEND flag

 include/net/bluetooth/bluetooth.h |  1 +
 include/net/bluetooth/hci.h       |  3 ---
 net/bluetooth/af_bluetooth.c      | 40 ++++++++++++++++++++++++++++
 net/bluetooth/l2cap_core.c        | 52 +++++++++++++++++++++++++------------
 net/bluetooth/l2cap_sock.c        |  6 +++++
 net/bluetooth/rfcomm/sock.c       |  7 ++++-
 6 files changed, 89 insertions(+), 20 deletions(-)