Skip to content

SLCAN/SLIP fixes and performance

Andre Naujoks linux-can lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3slip/slcan: added locking in wakeup functiondrivers/net/can/slcan.c drivers/net/slip/slip.c+6 -05 replies
2/3lib: introduce upper case hex ascii helpersinclude/linux/kernel.h lib/hexdump.c+13 -04 replies
3/3slcan: rewrite of slc_bump and slc_encapsdrivers/net/can/slcan.c+87 -492 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchOliver HartkoppMarc Kleine-Budde
1/3A-b A-b
2/3
3/3T-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] SLCAN/SLIP fixes and performance

Hi Dave,

these are some loosely related patches, that fix an ancient locking problem in the slip and slcan drivers, add general ASCII-HEX to bin functions for uppercase ASCII, fix the handling of CAN RTR frames in the slcan driver and increase the performance for the slcan driver.

As these patches mainly contain fixes for the slip/slcan drivers that require a tty layer fix included in 3.11, I would suggest to get the patches in via the net tree for the 3.12 cycle. They should apply properly on the latest net and mainline tree.

Best regards,
Andre

Andre Naujoks (3):
slip/slcan: added locking in wakeup function
lib: introduce upper case hex ascii helpers
slcan: rewrite of slc_bump and slc_encaps

 drivers/net/can/slcan.c | 139 +++++++++++++++++++++++++++++++-----------------
 drivers/net/slip/slip.c |   3 ++
 include/linux/kernel.h  |  11 ++++
 lib/hexdump.c           |   2 +
 4 files changed, 106 insertions(+), 49 deletions(-)
Signature · 1 line
1.8.4.rc3