Skip to content

hv: clean up dev_attr usage

Greg Kroah-Hartman lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13hv: use dev_groups for device attributesdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+18 -70 replies
2/13hv: move "state" bus attribute to dev_groupsdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+12 -70 replies
3/13hv: move "monitor_id" bus attribute to dev_groupsdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+12 -90 replies
4/13hv: move "modalias" bus attribute to dev_groupsdrivers/hv/vmbus_drv.c+12 -50 replies
5/13hv: move "class_id" bus attribute to dev_groupsdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+15 -100 replies
6/13hv: move "device_id" bus attribute to dev_groupsdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+14 -150 replies
7/13hv: make "monitor_pages" a "real" pointer arraydrivers/hv/channel.c drivers/hv/connection.c drivers/hv/hyperv_vmbus.h+15 -180 replies
8/13hv: move "client/server_monitor_pending" bus attributes to dev_groupsdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+46 -160 replies
9/13hv: move "client/server_monitor_latency" bus attributes to dev_groupsdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+38 -160 replies
10/13hv: move "client/server_monitor_conn_id" bus attributes to dev_groupsdrivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+38 -340 replies
11/13hv: delete vmbus_get_debug_info()drivers/hv/channel.c drivers/hv/vmbus_drv.c include/linux/hyperv.h+16 -370 replies
12/13hv: delete struct hv_dev_port_infodrivers/hv/hyperv_vmbus.h drivers/hv/vmbus_drv.c include/linux/hyperv.h+17 -420 replies
13/13hv: move ringbuffer bus attributes to dev_groupsdrivers/hv/vmbus_drv.c+146 -840 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] hv: clean up dev_attr usage

Hi,

Here's a set of 13 patches to get rid of the dev_attrs use in the hv bus code, as it will be going away soon. It's _way_ bigger than all other conversions I've had to do so far in the kernel, as you were using a "multiplexor" function for all of these files.

So, I've broken it up into individual show/store sysfs functions, and cleaned up a bunch of debug structures that aren't needed and shouldn't be exported to the rest of the kernel.

I've also fixed up some void * usage in the hv core, in patch 07, to make things simpler and not so "magic" when dealing with these pages. If you could review that one closely to ensure I didn't mess anything up, I would appreciate it.

Also, are all of these files really needed for sysfs? They seem to be all debugging stuff, shouldn't they go into debugfs if you really need/use them anymore?

KY, could you test these out? I don't have access to a hv system at the moment. I'll wait for your ack before applying them to any of my trees.

thanks,

greg k-h