hv: clean up dev_attr usage
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest13 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | hv: use dev_groups for device attributesdrivers/ drivers/ include/ | +18 | 0 replies | |
| 2/13 | hv: move "state" bus attribute to dev_groupsdrivers/ drivers/ include/ | +12 | 0 replies | |
| 3/13 | hv: move "monitor_id" bus attribute to dev_groupsdrivers/ drivers/ include/ | +12 | 0 replies | |
| 4/13 | hv: move "modalias" bus attribute to dev_groupsdrivers/ | +12 | 0 replies | |
| 5/13 | hv: move "class_id" bus attribute to dev_groupsdrivers/ drivers/ include/ | +15 | 0 replies | |
| 6/13 | hv: move "device_id" bus attribute to dev_groupsdrivers/ drivers/ include/ | +14 | 0 replies | |
| 7/13 | hv: make "monitor_pages" a "real" pointer arraydrivers/ drivers/ drivers/ | +15 | 0 replies | |
| 8/13 | hv: move "client/server_monitor_pending" bus attributes to dev_groupsdrivers/ drivers/ include/ | +46 | 0 replies | |
| 9/13 | hv: move "client/server_monitor_latency" bus attributes to dev_groupsdrivers/ drivers/ include/ | +38 | 0 replies | |
| 10/13 | hv: move "client/server_monitor_conn_id" bus attributes to dev_groupsdrivers/ drivers/ include/ | +38 | 0 replies | |
| 11/13 | hv: delete vmbus_get_debug_info()drivers/ drivers/ include/ | +16 | 0 replies | |
| 12/13 | hv: delete struct hv_dev_port_infodrivers/ drivers/ include/ | +17 | 0 replies | |
| 13/13 | hv: move ringbuffer bus attributes to dev_groupsdrivers/ | +146 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/13] hv: clean up dev_attr usage
Hi,
Here's a set of 13 patches to get rid of the dev_attrs use in the hv bus code, as it will be going away soon. It's _way_ bigger than all other conversions I've had to do so far in the kernel, as you were using a "multiplexor" function for all of these files.
So, I've broken it up into individual show/store sysfs functions, and cleaned up a bunch of debug structures that aren't needed and shouldn't be exported to the rest of the kernel.
I've also fixed up some void * usage in the hv core, in patch 07, to make things simpler and not so "magic" when dealing with these pages. If you could review that one closely to ensure I didn't mess anything up, I would appreciate it.
Also, are all of these files really needed for sysfs? They seem to be all debugging stuff, shouldn't they go into debugfs if you really need/use them anymore?
KY, could you test these out? I don't have access to a hv system at the moment. I'll wait for your ack before applying them to any of my trees.
thanks,
greg k-h