Skip to content

perf tools: kcore improvements

Adrian Hunter lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 2 repliesIn review
  2. v68 patches 4 repliesSuperseded
  3. v59 patches 7 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v49 patches4 repliesSuperseded
v310 patches0 repliesSuperseded
v210 patches1 replySuperseded
v111 patches1 replySuperseded

Changes in v7 from the cover letter

perf tools: validate kcore module addresses
Dropped because it has been applied
perf tools: workaround objdump difficulties with kcore
Dropped because it has been applied
perf tools: Add map_groups__find_ams()
New patch
perf tools: fix annotate_browser__callq()
Changed to use map_groups__find_ams()
perf tools: find kcore symbols on other maps
Changed to use map_groups__find_ams()
perf tools: another fix for annotate_browser__callq()
New patch

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf tools: Add map_groups__find_ams()tools/perf/util/map.c tools/perf/util/map.h+21 -00 replies
2/7perf tools: fix annotate_browser__callq()tools/perf/ui/browsers/annotate.c+10 -110 replies
3/7perf tools: find kcore symbols on other mapstools/perf/util/annotate.c+9 -130 replies
4/7perf tools: add copyfile_mode()tools/perf/util/util.c tools/perf/util/util.h+14 -50 replies
5/7perf buildid-cache: add ability to add kcore to the cachetools/perf/Documentation/perf-buildid-cache.txt tools/perf/builtin-buildid-cache.c tools/perf/util/symbol-elf.c +3 more+568 -12 replies
6/7perf tools: add ability to find kcore in build-id cachetools/perf/util/symbol.c+103 -440 replies
7/7perf tools: another fix for annotate_browser__callq()tools/perf/ui/browsers/annotate.c tools/perf/util/map.c tools/perf/util/map.h+38 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH V7 0/7] perf tools: kcore improvements

Hi

Here are some improvements for using kcore (version 7). There are 3 improvements:

- validate that kcore matches the perf.data modules
- workaround objdump difficulties with kcore
- add kcore to the build-id cache

Changes in V7:
perf tools: validate kcore module addresses
Dropped because it has been applied
perf tools: workaround objdump difficulties with kcore
Dropped because it has been applied
perf tools: Add map_groups__find_ams()
New patch
perf tools: fix annotate_browser__callq()
Changed to use map_groups__find_ams()
perf tools: find kcore symbols on other maps
Changed to use map_groups__find_ams()
perf tools: another fix for annotate_browser__callq()
New patch

Changes in V6:
perf tools: make a separate function to parse /proc/modules
Dropped because it has been applied
perf tools: workaround objdump difficulties with kcore
Renamed some functions and reordered parameters
perf buildid-cache: add ability to add kcore to the cache
Renamed some functions and reordered parameters

Changes in V5:
perf tools: make a separate function to parse /proc/modules
Use scnprintf not snprintf
perf tools: validate kcore module addresses
Fix check for mi->name not allocated
perf buildid-cache: add ability to add kcore to the cache
Use scnprintf not snprintf
perf tools: add ability to find kcore in build-id cache
Use scnprintf not snprintf

Changes in V4:
perf tools: fix path unpopulated in machine__create_modules()
Dropped because it has been applied
perf buildid-cache: add ability to add kcore to the cache
Tweaked Documentation/perf-buildid-cache.txt
perf tools: add ability to find kcore in build-id cache
Changed to check read access to /proc/kcore before skipping the buildid cache

Changes in V3:
perf tools: workaround objdump difficulties with kcore
change strncpy to strlcpy
perf buildid-cache: add ability to add kcore to the cache
change strncpy to strlcpy
perf tools: add ability to find kcore in build-id cache
change strncpy to strlcpy
Changes in V2:
perf tools: fix buildid cache handling of kallsyms with kcore
Dropped because it has been applied
perf tools: fix path unpopulated in machine__create_modules()
Use 'modules' pointer

Adrian Hunter (6):
perf tools: fix annotate_browser__callq()
perf tools: find kcore symbols on other maps perf tools: add copyfile_mode()
perf buildid-cache: add ability to add kcore to the cache perf tools: add ability to find kcore in build-id cache perf tools: another fix for annotate_browser__callq()

Arnaldo Carvalho de Melo (1):
perf tools: Add map_groups__find_ams()

 tools/perf/Documentation/perf-buildid-cache.txt |  13 +
 tools/perf/builtin-buildid-cache.c              | 148 +++++++++-
 tools/perf/ui/browsers/annotate.c               |  24 +-
 tools/perf/util/annotate.c                      |  22 +-
 tools/perf/util/map.c                           |  48 +++-
 tools/perf/util/map.h                           |   7 +
 tools/perf/util/symbol-elf.c                    | 358 ++++++++++++++++++++++++
 tools/perf/util/symbol-minimal.c                |   6 +
 tools/perf/util/symbol.c                        | 188 ++++++++++---
 tools/perf/util/symbol.h                        |   3 +
 tools/perf/util/util.c                          |  18 +-
 tools/perf/util/util.h                          |   1 +
 12 files changed, 761 insertions(+), 75 deletions(-)

Regards
Adrian