Skip to content

Fixes for various minor Coverity issues, volume 2

Matthew Daley xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest28 patches 39 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/28gnttab: remove unused shared header lookupxen/common/grant_table.c+0 -11 reply
2/28libxc: fix memory leak in load_p2m_frame_list error handlingtools/libxc/xc_domain_restore.c+1 -01 reply
3/28libxc: move munmap into the loop it's needed in in change_ptetools/libxc/xc_offline_page.c+3 -33 replies
4/28libxl: fix libxl_string_list_length and its only callertools/libxl/libxl.c tools/libxl/libxl_bootloader.c+2 -24 replies
5/28libxl: fix dispose without init of disk in cd_inserttools/libxl/xl_cmdimpl.c+2 -41 reply
6/28libxl: fix leak of corename in handle_domain_deathtools/libxl/xl_cmdimpl.c+1 -00 replies
7/28libxl: fix leak of config_data in main_cpupoolcreatetools/libxl/xl_cmdimpl.c+1 -00 replies
8/28libxl: fix leak of rune in main_remustools/libxl/xl_cmdimpl.c+3 -00 replies
9/28libxl: fix out-of-memory check in parse_global_configtools/libxl/xl.c+2 -20 replies
10/28libxl: only free cpupoolinfo if necessary in libxl_list_cpupooltools/libxl/libxl.c+2 -12 replies
11/28libxl: only put poller if already gotten in libxl_event_waittools/libxl/libxl_event.c+1 -19 replies
12/28libxl: only free cputopology if it was allocated in libxl__get_numa_candidatetools/libxl/libxl_numa.c+2 -15 replies
13/28libxl: only free cputopology if it was allocated in libxl_{cpu, node}map_to_{node, cpu}maptools/libxl/libxl_utils.c+4 -26 replies
14/28libxl: only free console reader if it was allocated in main_dmesgtools/libxl/xl_cmdimpl.c+2 -10 replies
15/28libxl: fix typo in libxl__hotplug_nic error checkingtools/libxl/libxl_linux.c+1 -10 replies
16/28libxl: fix file open failure check in libxl__file_reference_maptools/libxl/libxl_internal.c+1 -10 replies
17/28libxl: gettimeofday doesn't return an errno on failuretools/libxl/xl_cmdimpl.c+2 -23 replies
18/28xenstored: handle unlikely failure better in ask_parentstools/xenstore/xenstored_core.c+3 -12 replies
19/28xenstored: fix faulty check for bad handle in domain_inittools/xenstore/xenstored_domain.c+1 -10 replies
20/28xenstore: check socket path length before copying ittools/xenstore/xs.c+4 -00 replies
21/28mini-os: fix nodename generation in init_netfrontextras/mini-os/netfront.c+4 -21 reply
22/28mini-os: fix various memory leaks in blkfrontextras/mini-os/blkfront.c+7 -41 reply
23/28mini-os: fix various memory leaks in {fb, kbd}frontextras/mini-os/fbfront.c+31 -1710 replies
24/28mini-os: fix various memory leaks in netfrontextras/mini-os/netfront.c+11 -61 reply
25/28mini-os: fix various memory leaks in pcifrontextras/mini-os/pcifront.c+19 -101 reply
26/28mini-os: fix various memory leaks in consfrontextras/mini-os/console/xenbus.c+5 -41 reply
27/28mini-os: fix various memory leaks in various locationsextras/mini-os/kernel.c extras/mini-os/lib/xs.c+7 -21 reply
28/28gdbsx: clear sockaddr before using ittools/debugger/gdbsx/gx/gx_comm.c+1 -00 replies

Reviews trailers per patch

10 of 28 patches have a Reviewed-by or Acked-by.

PatchSamuel ThibaultTim DeeganDario FaggioliIan Campbell
1/28R-b
2/28
3/28
4/28
5/28
6/28
7/28
8/28
9/28
10/28
11/28A-b
12/28
13/28A-b
14/28
15/28
16/28
17/28
18/28
19/28
20/28
21/28A-b
22/28A-b
23/28A-b A-b A-b
24/28A-b
25/28A-b
26/28A-b
27/28A-b
28/28

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/28] Fixes for various minor Coverity issues, volume 2

Tested by building and creating a few PV and HVM domains. There shouldn't be anything too complicated or controversial here.

Matthew Daley (28):
gnttab: remove unused shared header lookup
libxc: fix memory leak in load_p2m_frame_list error handling
libxc: move munmap into the loop it's needed in in change_pte
libxl: fix libxl_string_list_length and its only caller
libxl: fix dispose without init of disk in cd_insert
libxl: fix leak of corename in handle_domain_death
libxl: fix leak of config_data in main_cpupoolcreate
libxl: fix leak of rune in main_remus
libxl: fix out-of-memory check in parse_global_config
libxl: only free cpupoolinfo if necessary in libxl_list_cpupool
libxl: only put poller if already gotten in libxl_event_wait
libxl: only free cputopology if it was allocated in
libxl__get_numa_candidate
libxl: only free cputopology if it was allocated in
libxl_{cpu,node}map_to_{node,cpu}map
libxl: only free console reader if it was allocated in main_dmesg
libxl: fix typo in libxl__hotplug_nic error checking
libxl: fix file open failure check in libxl__file_reference_map
libxl: gettimeofday doesn't return an errno on failure
xenstored: handle unlikely failure better in ask_parents
xenstored: fix faulty check for bad handle in domain_init
xenstore: check socket path length before copying it
mini-os: fix nodename generation in init_netfront
mini-os: fix various memory leaks in blkfront
mini-os: fix various memory leaks in {fb,kbd}front
mini-os: fix various memory leaks in netfront
mini-os: fix various memory leaks in pcifront
mini-os: fix various memory leaks in consfront
mini-os: fix various memory leaks in various locations
gdbsx: clear sockaddr before using it

 extras/mini-os/blkfront.c         |   11 +++++----
 extras/mini-os/console/xenbus.c   |    9 +++----
 extras/mini-os/fbfront.c          |   48 ++++++++++++++++++++++++-------------
 extras/mini-os/kernel.c           |    7 ++++--
 extras/mini-os/lib/xs.c           |    2 ++
 extras/mini-os/netfront.c         |   23 +++++++++++-------
 extras/mini-os/pcifront.c         |   29 ++++++++++++++--------
 tools/debugger/gdbsx/gx/gx_comm.c |    1 +
 tools/libxc/xc_domain_restore.c   |    1 +
 tools/libxc/xc_offline_page.c     |    6 ++---
 tools/libxl/libxl.c               |    5 ++--
 tools/libxl/libxl_bootloader.c    |    2 +-
 tools/libxl/libxl_event.c         |    2 +-
 tools/libxl/libxl_internal.c      |    2 +-
 tools/libxl/libxl_linux.c         |    2 +-
 tools/libxl/libxl_numa.c          |    3 ++-
 tools/libxl/libxl_utils.c         |    6 +++--
 tools/libxl/xl.c                  |    4 ++--
 tools/libxl/xl_cmdimpl.c          |   18 ++++++++------
 tools/xenstore/xenstored_core.c   |    4 +++-
 tools/xenstore/xenstored_domain.c |    2 +-
 tools/xenstore/xs.c               |    4 ++++
 xen/common/grant_table.c          |    1 -
 23 files changed, 123 insertions(+), 69 deletions(-)
Signature · 1 line
1.7.10.4