Skip to content

xfs: rework xfs_inactive()

Brian Foster linux-xfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 4 repliesIn review
  2. v24 patches 4 repliesSuperseded
  3. v13 patches 11 repliesSuperseded

Changes in v3 from the cover letter

- Error handling fixes: cancel transaction before iunlock. v2:
- Cleaned up error handling throughout the set.
- Added inode locking to xfs_inactive_symlink().
- Added patch 4 to clean up xfs_inactive() after transaction management purge.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xfs: push down inactive transaction mgmt for remote symlinksfs/xfs/xfs_inode.c fs/xfs/xfs_symlink.c fs/xfs/xfs_symlink.h+49 -541 reply
2/4xfs: push down inactive transaction mgmt for truncatefs/xfs/xfs_inode.c+68 -491 reply
3/4xfs: push down inactive transaction mgmt for ifreefs/xfs/xfs_inode.c+71 -501 reply
4/4xfs: clean up xfs_inactive() error handling, kill VN_INACTIVE_[NO]CACHEfs/xfs/xfs_inode.c fs/xfs/xfs_inode.h fs/xfs/xfs_vnode.h+12 -260 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDave Chinner
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] xfs: rework xfs_inactive()

Hi all,

This set reworks the xfs_inactive() path with the intent to clean up the transaction management overall. This is preparation work for the free inode btree set and subsequent work in the area. The patches clean up the remote symlink work, truncate work and ifree work respectively.

This passes through a quick xfstests run (with debug and lockdep) without any major explosions. Thoughts appreciated.

Brian

v3:
- Error handling fixes: cancel transaction before iunlock. v2:
- Cleaned up error handling throughout the set.
- Added inode locking to xfs_inactive_symlink().
- Added patch 4 to clean up xfs_inactive() after transaction management purge.

Brian Foster (4):
xfs: push down inactive transaction mgmt for remote symlinks
xfs: push down inactive transaction mgmt for truncate
xfs: push down inactive transaction mgmt for ifree
xfs: clean up xfs_inactive() error handling, kill
VN_INACTIVE_[NO]CACHE

 fs/xfs/xfs_inode.c   | 241 +++++++++++++++++++++++++++++----------------------
 fs/xfs/xfs_inode.h   |   2 +-
 fs/xfs/xfs_symlink.c |  86 +++++++++---------
 fs/xfs/xfs_symlink.h |   2 +-
 fs/xfs/xfs_vnode.h   |   8 --
 5 files changed, 180 insertions(+), 159 deletions(-)
Signature · 6 lines
1.8.1.4

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs