Skip to content

Remove useless vblank waits on Haswell

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915: WARN in case PIPECONF is already enableddrivers/gpu/drm/i915/intel_display.c+1 -12 replies
2/4drm/i915: don't intel_wait_for_vblank inside intel_enable_pipedrivers/gpu/drm/i915/intel_display.c+4 -30 replies
3/4drm/i915: remove useless vblank wait form haswell_crtc_enabledrivers/gpu/drm/i915/intel_display.c+0 -10 replies
4/4drm/i915: skip useless vblank wait on Haswell audio sequencedrivers/gpu/drm/i915/intel_display.c+11 -35 replies
4/4drm/i915: skip useless vblank wait on Haswell audio sequencedrivers/gpu/drm/i915/intel_display.c+0 -40 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchChris Wilson
1/4
2/4
3/4
4/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] Remove useless vblank waits on Haswell

From: Paulo Zanoni <[email protected]>

Hi

This series gets rid of those messages saying that the vblank wait timed out on my Haswell machine. It saves 2 timeouts per pipe (one at mode_set, one at crtc_enable), so it's 100ms we save per modeset.

The big idea exercised by this patch is that the pipe doesn't really start running after we enable PIPECONF, so we had some useless waits. This idea probably also applies to ILK/SNB/IVB and perhaps we could try to save some vblanks on those Gens too.

I tested these patches on top of the 4 patches that fix the Haswell underruns + the 2 IPS patches I just sent.

Thanks,
Paulo

Paulo Zanoni (4):
drm/i915: WARN in case PIPECONF is already enabled drm/i915: don't intel_wait_for_vblank inside intel_enable_pipe drm/i915: remove useless vblank wait form haswell_crtc_enable drm/i915: skip useless vblank wait on Haswell audio sequence

 drivers/gpu/drm/i915/intel_display.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.3.1