Skip to content

Configure metadata overlap checks at runtime

Max Reitz qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyApplied
  2. v16 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- rebased on Kevin's block branch
- patch 1: affects line numbers, diff environments and one overlap check that has been removed in the meantime
- patch 2: line number changes
- patch 5: replaced QCOW2_OL_SNAPSHOT_TABLE by QCOW2_OL_INACTIVE_L1 in the definition of QCOW2_OL_CACHED (the former one is already a part of QCOW2_OL_CONSTANT, the latter one was missing)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6qcow2: Use negated overflow check maskblock/qcow2-cache.c block/qcow2-cluster.c block/qcow2-refcount.c +3 more+29 -380 replies
2/6qcow2: Make overlap check mask variableblock/qcow2-refcount.c block/qcow2.c block/qcow2.h+5 -40 replies
3/6qcow2: Add overlap-check optionsblock/qcow2.c block/qcow2.h+55 -00 replies
4/6qcow2: Array assigning options to OL check bitsblock/qcow2.c+11 -00 replies
5/6qcow2: Add more overlap check bitmask macrosblock/qcow2.h+11 -30 replies
6/6qcow2: Evaluate overlap check optionsblock/qcow2.c+28 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/6] Configure metadata overlap checks at runtime

This series changes the way of selecting what metadata overlap checks to perform from (currently) using a macro to using a variable contained in BDRVQcowState which can be configured at runtime through several command line options.

v2:
- rebased on Kevin's block branch
- patch 1: affects line numbers, diff environments and one overlap check that has been removed in the meantime
- patch 2: line number changes
- patch 5: replaced QCOW2_OL_SNAPSHOT_TABLE by QCOW2_OL_INACTIVE_L1 in the definition of QCOW2_OL_CACHED (the former one is already a part of QCOW2_OL_CONSTANT, the latter one was missing)

Max Reitz (6):
qcow2: Use negated overflow check mask
qcow2: Make overlap check mask variable
qcow2: Add overlap-check options
qcow2: Array assigning options to OL check bits
qcow2: Add more overlap check bitmask macros
qcow2: Evaluate overlap check options

 block/qcow2-cache.c    |  8 ++---
 block/qcow2-cluster.c  | 16 ++++-----
 block/qcow2-refcount.c | 22 ++++++------
 block/qcow2-snapshot.c | 12 +++----
 block/qcow2.c          | 91 ++++++++++++++++++++++++++++++++++++++++++++++++--
 block/qcow2.h          | 30 +++++++++++++----
 6 files changed, 136 insertions(+), 43 deletions(-)
Signature · 1 line
1.8.3.1