Skip to content

hfsplus: introduce functionality of attributes file creation

Vyacheslav Dubeyko linux-fsdevel 2 versions – In review

Get series with b4
b4 am 1380528305.2275.12.camel@slavad-ubuntu

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

* SETOFFSET macro was removed (Andrew Morton).
* Record offsets logic was reworked in hfsplus_init_header_node() (Al Viro).
* AttributesFile's header node's bitmap is initialized by memset() (Al Viro).
* Logic of checking attributes tree state before AttributesFile creation was reworked for HFSPLUS_CREATING_ATTR_TREE case (Andrew Morton).
* Setting error code was added after read_mapping_page()
call in hfsplus_create_attributes_file() method (Andrew Morton).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hfsplus: add metadata file's clump size calculation functionalityfs/hfsplus/btree.c fs/hfsplus/hfsplus_fs.h+113 -00 replies
2/3hfsplus: implement attributes file's header node initialization codefs/hfsplus/hfsplus_raw.h fs/hfsplus/xattr.c+68 -00 replies
3/3hfsplus: implement attributes file creation functionalityfs/hfsplus/hfsplus_fs.h fs/hfsplus/super.c fs/hfsplus/xattr.c+151 -21 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchHin-Tak Leung
1/3
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] hfsplus: introduce functionality of attributes file creation

Hi,

This is second version of the AttributesFile creation patchset.

v1->v2
* SETOFFSET macro was removed (Andrew Morton).
* Record offsets logic was reworked in hfsplus_init_header_node() (Al Viro).
* AttributesFile's header node's bitmap is initialized by memset() (Al Viro).
* Logic of checking attributes tree state before AttributesFile creation was reworked for HFSPLUS_CREATING_ATTR_TREE case (Andrew Morton).
* Setting error code was added after read_mapping_page()
call in hfsplus_create_attributes_file() method (Andrew Morton).

There are situation when HFS+ volume had been created without AttributesFile. Such situation can take place because of using old mkfs.hfs utility or creation HFS+ volume without taking in mind necessity to use xattrs. For example, Mac OS X 10.4 (Tiger) doesn't create AttributesFile during mkfs phase. Also it is a very frequent situation for the case of users that created HFS+ volumes under Linux. As a result, xattrs and POSIX ACLs on HFS+ volume are unavailable for such users.

This patch set implements functionality of AttributesFile creation on HFS+ volume in the case of this metadata file absence during operation of xattr creation.

With the best regards,
Vyacheslav Dubeyko.
---
Vyacheslav Dubeyko (1):
hfsplus: introduce functionality of attributes file creation

 fs/hfsplus/btree.c       |  112 +++++++++++++++++++++++++
 fs/hfsplus/hfsplus_fs.h  |   10 +++
 fs/hfsplus/hfsplus_raw.h |    3 +
 fs/hfsplus/super.c       |    2 +
 fs/hfsplus/xattr.c       |  207 +++++++++++++++++++++++++++++++++++++++++++++-
 5 files changed, 332 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.9.5