blockdev-add QMP command
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest17 patches 0 repliesNew
- v217 patches 20 repliesSuperseded
- v117 patches 38 repliesSuperseded
Changes in v3 from the cover letter
- Fixed an error path in qmp_blockdev_add()
- Updated formatting of QAPI schema comments
- Removed I/O throttling from documentation (QMP example)
- Fixed typo in unused help text while moving it
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | qapi-types/visit.py: Pass whole expr dict for structsscripts/ scripts/ | +14 | 0 replies | |
| 2/17 | qapi-types/visit.py: Inheritance for structsdocs/ scripts/ scripts/ | +37 | 0 replies | |
| 3/17 | blockdev: Introduce DriveInfo.enable_auto_delblockdev.c include/ | +17 | 0 replies | |
| 4/17 | blockdev: 'blockdev-add' QMP commandblockdev.c qapi-schema.json qmp-commands.hx | +348 | 0 replies | |
| 5/17 | blockdev: Separate ID generation from DriveInfo creationblockdev.c include/ util/ | +24 | 0 replies | |
| 6/17 | blockdev: Pass QDict to blockdev_init()blockdev.c | +17 | 0 replies | |
| 7/17 | blockdev: Move parsing of 'media' option to drive_initblockdev.c | +50 | 0 replies | |
| 8/17 | blockdev: Move parsing of 'if' option to drive_initblockdev.c | +22 | 0 replies | |
| 9/17 | blockdev: Moving parsing of geometry options to drive_initblockdev.c | +69 | 0 replies | |
| 10/17 | blockdev: Move parsing of 'boot' option to drive_initblockdev.c | +11 | 0 replies | |
| 11/17 | blockdev: Move bus/unit/index processing to drive_initblockdev.c | +73 | 0 replies | |
| 12/17 | blockdev: Move virtio-blk device creation to drive_initblockdev.c | +27 | 0 replies | |
| 13/17 | blockdev: Remove IF_* check for read-only blockdev_initblockdev.c hw/ hw/ +8 more | +42 | 0 replies | |
| 14/17 | qemu-iotests: Check autodel behaviour for device_deltests/ tests/ tests/ +1 more | +222 | 0 replies | |
| 15/17 | blockdev: Remove 'media' parameter from blockdev_init()blockdev.c | +15 | 0 replies | |
| 16/17 | blockdev: Don't disable COR automatically with blockdev-addblock.c blockdev.c | +34 | 0 replies | |
| 17/17 | blockdev: blockdev_init() error conversionblockdev.c | +33 | 0 replies |
Reviews trailers per patch
16 of 17 patches have a Reviewed-by or Acked-by.
| Patch | Eric Blake | Wenchao Xia | Max Reitz | Benoit Canet |
|---|---|---|---|---|
| 1/17 | R-b | |||
| 2/17 | R-b | |||
| 3/17 | R-b | R-b | ||
| 4/17 | ||||
| 5/17 | R-b | R-b | R-b | |
| 6/17 | R-b | R-b | ||
| 7/17 | R-b | R-b | ||
| 8/17 | R-b | R-b | ||
| 9/17 | R-b | |||
| 10/17 | R-b | |||
| 11/17 | R-b | R-b | ||
| 12/17 | R-b | R-b | ||
| 13/17 | R-b | |||
| 14/17 | R-b | R-b | ||
| 15/17 | R-b | R-b | ||
| 16/17 | R-b | R-b | ||
| 17/17 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [Qemu-devel] [PATCH v3 00/17] blockdev-add QMP command
This series adds a blockdev-add QMP command and a row of cleanup patches to separate legacy -drive/drive_add behaviour from blockdev_init() to the wrapper function drive_init().
v2:
- Removed I/O throttling and copy-on-read options from the schema: Both are candidates for becoming block filters instead. For the time being, you can use the existing QMP commands in order to enable I/O throttling on a device created with blockdev-add in a second step.
- Fixed some error paths in drive_init()
- Fixed segfault on drive_del for a device added with blockdev-add
- Minor cleanups and fixes to code and documentation
v3:
- Fixed an error path in qmp_blockdev_add()
- Updated formatting of QAPI schema comments
- Removed I/O throttling from documentation (QMP example)
- Fixed typo in unused help text while moving it
Kevin Wolf (17):
qapi-types/visit.py: Pass whole expr dict for structs qapi-types/visit.py: Inheritance for structs
blockdev: Introduce DriveInfo.enable_auto_del
blockdev: 'blockdev-add' QMP command
blockdev: Separate ID generation from DriveInfo creation
blockdev: Pass QDict to blockdev_init()
blockdev: Move parsing of 'media' option to drive_init
blockdev: Move parsing of 'if' option to drive_init
blockdev: Moving parsing of geometry options to drive_init
blockdev: Move parsing of 'boot' option to drive_init
blockdev: Move bus/unit/index processing to drive_init
blockdev: Move virtio-blk device creation to drive_init
blockdev: Remove IF_* check for read-only blockdev_init
qemu-iotests: Check autodel behaviour for device_del
blockdev: Remove 'media' parameter from blockdev_init()
blockdev: Don't disable COR automatically with blockdev-add
blockdev: blockdev_init() error conversion
block.c | 9 +- blockdev.c | 669 +++++++++++++++++++++++---------------- docs/qapi-code-gen.txt | 17 + hw/block/m25p80.c | 5 + hw/block/xen_disk.c | 5 + hw/sd/milkymist-memcard.c | 4 + hw/sd/omap_mmc.c | 6 + hw/sd/pl181.c | 4 + hw/sd/pxa2xx_mmci.c | 3 + hw/sd/sd.c | 5 + hw/sd/sdhci.c | 3 + hw/sd/ssi-sd.c | 3 + include/qemu/option.h | 1 + include/sysemu/blockdev.h | 1 + qapi-schema.json | 236 ++++++++++++++ qmp-commands.hx | 55 ++++ scripts/qapi-types.py | 15 +- scripts/qapi-visit.py | 26 +- tests/qemu-iotests/051.out | 5 +- tests/qemu-iotests/064 | 133 ++++++++ tests/qemu-iotests/064.out | 80 +++++ tests/qemu-iotests/common.filter | 8 + tests/qemu-iotests/group | 1 + util/qemu-option.c | 6 + 24 files changed, 1011 insertions(+), 289 deletions(-) create mode 100755 tests/qemu-iotests/064 create mode 100644 tests/qemu-iotests/064.out
Signature · 1 line
1.8.1.4