Skip to content

RFC random driver changes

Theodore Ts'o lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12random: run random_int_secret_init() run after all late_initcallsdrivers/char/random.c include/linux/random.h init/main.c+4 -20 replies
2/12random: Statically compute poolbitshift, poolbytes, poolbitsdrivers/char/random.c+19 -200 replies
3/12random: Allow fractional bits to be trackeddrivers/char/random.c+81 -372 replies
4/12random: Account for entropy loss due to overwritesdrivers/char/random.c+52 -80 replies
5/12random: fix the tracepoint for get_random_bytes(_arch)drivers/char/random.c include/trace/events/random.h+36 -20 replies
6/12random: optimize spinlock use in add_device_randomness()drivers/char/random.c+9 -40 replies
7/12random: allow architectures to optionally define random_get_entropy()drivers/char/random.c include/linux/timex.h+21 -42 replies
8/12random: mix in architectural randomness earlier in extract_buf()drivers/char/random.c+11 -112 replies
9/12random: optimize the entropy_store structuredrivers/char/random.c+8 -80 replies
10/12random: cap the rate which the /dev/urandom pool gets reseededdrivers/char/random.c+25 -05 replies
11/12random: speed up the fast_mix function by a factor of fourdrivers/char/random.c+17 -130 replies
12/12random: adjust the generator polynomials in the mixing function slightlydrivers/char/random.c+50 -541 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH, RFC 00/12] random driver changes

Recent events have inspired me to take a closer look at the /dev/random driver and make a number of changes to improve it. The changes reflect relatively minor changes across the entire /dev/random architecture, including:

* how we collect entropy on non-x86 architectures
* optimizing the CPU overhead when we collect entropy
* improving our entropy accumulation estimates
* small changes to the mixing function suggested by researchers who have been analyzing the /dev/random driver

I would appreciate folks taking a look at the changes and making any comments, asking questions, etc.

Cheers!

- Ted

H. Peter Anvin (3):
random: Statically compute poolbitshift, poolbytes, poolbits
random: Allow fractional bits to be tracked
random: Account for entropy loss due to overwrites

Theodore Ts'o (9):
random: run random_int_secret_init() run after all late_initcalls
random: fix the tracepoint for get_random_bytes(_arch)
random: optimize spinlock use in add_device_randomness()
random: allow architectures to optionally define random_get_entropy()
random: mix in architectural randomness earlier in extract_buf()
random: optimize the entropy_store structure
random: cap the rate which the /dev/urandom pool gets reseeded
random: speed up the fast_mix function by a factor of four
random: adjust the generator polynomials in the mixing function
slightly

 drivers/char/random.c         | 419 +++++++++++++++++++++++++++---------------
 include/linux/random.h        |   1 +
 include/linux/timex.h         |  17 ++
 include/trace/events/random.h |  33 +++-
 init/main.c                   |   2 +
 5 files changed, 321 insertions(+), 151 deletions(-)
Signature · 1 line
1.7.12.rc0.22.gcdd159b