driver core: prevent deferred probe with platform_driver_probe
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | driver core: prevent deferred probe with platform_driver_probedrivers/ include/ | +14 | 0 replies | |
| 2/7 | mmc: mvsdio: fix deferred probe from __initdrivers/ | +6 | 0 replies | |
| 3/7 | mtd: atmel_nand: fix deferred probe from __initdrivers/ | +7 | 0 replies | |
| 4/7 | pcmcia: at91_cf: fix deferred probe from __initdrivers/ | +5 | 1 reply | |
| 5/7 | usb: gadget: pxa25x_udc: fix deferred probe from __initdrivers/ | +5 | 0 replies | |
| 6/7 | usb: phy: gpio-vbus: fix deferred probe from __initdrivers/ | +5 | 0 replies | |
| 7/7 | backlight: atmel-pwm-bl: fix deferred probe from __initdrivers/ | +5 | 0 replies |
Reviews trailers per patch
1 of 7 patches has a Reviewed-by or Acked-by.
| Patch | Nicolas Ferre |
|---|---|
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | A-b |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/7] driver core: prevent deferred probe with platform_driver_probe
Deferred probing cannot be used with platform_driver_probe as by the time probing is retried either the driver has been unregistered or its probe function has been set to platform_drv_probe_fail.
With commit e9354576 ("gpiolib: Defer failed gpio requests by default") the gpio subsystem started returning -EPROBE_DEFER, which in turn several platform drivers using platform_driver_probe return to driver core. Other subsystems (e.g. regulator) has since started doing the same.
The first patch in this series prevents platform drivers using platform_driver_probe from requesting probe deferral while warning that it is not supported.
The remaining patches move six platform-driver probe functions that rely on gpio_request out of __init. There are likely other probe functions that might return -EPROBE_DEFER and should be moved out of __init as well.
Note that the mvsdio, at91_cf and pxa25x_udc patches are completely untested.
Johan
Johan Hovold (7):
driver core: prevent deferred probe with platform_driver_probe
mmc: mvsdio: fix deferred probe from __init
mtd: atmel_nand: fix deferred probe from __init
pcmcia: at91_cf: fix deferred probe from __init
usb: gadget: pxa25x_udc: fix deferred probe from __init
usb: phy: gpio-vbus: fix deferred probe from __init
backlight: atmel-pwm-bl: fix deferred probe from __init
drivers/base/platform.c | 17 +++++++++++++---- drivers/mmc/host/mvsdio.c | 11 ++++++----- drivers/mtd/nand/atmel_nand.c | 13 +++++++------ drivers/pcmcia/at91_cf.c | 11 +++++------ drivers/usb/gadget/pxa25x_udc.c | 9 +++++---- drivers/usb/phy/phy-gpio-vbus-usb.c | 11 +++++------ drivers/video/backlight/atmel-pwm-bl.c | 9 +++++---- include/linux/platform_device.h | 1 + 8 files changed, 47 insertions(+), 35 deletions(-)
Signature · 1 line
1.8.3.2