Skip to content

Bluetooth: Cleanups and LE advertising support

[email protected] linux-bluetooth 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 3 repliesIn review
  2. v18 patches 16 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Bluetooth: Add clarifying comment to bt_sock_wait_state()net/bluetooth/af_bluetooth.c+1 -00 replies
2/7Bluetooth: Clean up socket locking in l2cap_sock_recvmsgnet/bluetooth/l2cap_sock.c+2 -21 reply
3/7Bluetooth: Fix busy return for mgmt_set_powered in some casesnet/bluetooth/mgmt.c+6 -60 replies
4/7Bluetooth: Move mgmt response convenience functions to a better locationnet/bluetooth/mgmt.c+30 -300 replies
5/7Bluetooth: Use async request for LE enable/disableinclude/net/bluetooth/hci_core.h net/bluetooth/hci_event.c net/bluetooth/mgmt.c+32 -470 replies
6/7Bluetooth: Add new mgmt setting for LE advertisinginclude/net/bluetooth/mgmt.h net/bluetooth/hci_event.c net/bluetooth/mgmt.c+22 -10 replies
7/7Bluetooth: Add new mgmt_set_advertising commandinclude/net/bluetooth/mgmt.h net/bluetooth/mgmt.c+98 -12 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchMarcel Holtmann
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] Bluetooth: Cleanups and LE advertising support

Hi,

Here's an updated set based on feedback on the first one. The mgmt_valid_hdev patch has been dropped since it's a trivial one and I didn't want the debate over it to slow down the overall progress of this set.

The main difference to the initial set_le and set_advertising code is that I now let the hci_event.c handlers take care of setting the right values of the dev_flags bits. This works fine since these handlers are always executed before the async request callbacks which then get called with dev_flags already having the correct value. The benefit of using the event handlers like this is that we retain at least partial support for raw HCI access (hciconfig) by ensuring that the kernel state flags are always correct.

Johan

----------------------------------------------------------------
Johan Hedberg (7):
Bluetooth: Add clarifying comment to bt_sock_wait_state()
Bluetooth: Clean up socket locking in l2cap_sock_recvmsg
Bluetooth: Fix busy return for mgmt_set_powered in some cases
Bluetooth: Move mgmt response convenience functions to a better location
Bluetooth: Use async request for LE enable/disable
Bluetooth: Add new mgmt setting for LE advertising
Bluetooth: Add new mgmt_set_advertising command

 include/net/bluetooth/hci_core.h |   1 -
 include/net/bluetooth/mgmt.h     |   3 +
 net/bluetooth/af_bluetooth.c     |   1 +
 net/bluetooth/hci_event.c        |  12 +-
 net/bluetooth/l2cap_sock.c       |   4 +-
 net/bluetooth/mgmt.c             | 257 ++++++++++++++++++++++++++------------
 6 files changed, 191 insertions(+), 87 deletions(-)