Skip to content

Organize intel_drv.h

Paulo Zanoni intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915: reorganize intel_drv.hdrivers/gpu/drm/i915/intel_drv.h+214 -1960 replies
2/5drm/i915: make intel_pipe_has_type staticdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+15 -170 replies
3/5drm/i915: make intel_crtc_load_lut staticdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+78 -790 replies
4/5drm/i915: make intel_crtc_fb_gamma_{set, get} staticdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h drivers/gpu/drm/i915/intel_fb.c+21 -250 replies
5/5drm/i915: make hsw_{disable, restore}_lcpll staticdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_drv.h+3 -60 replies

Reviews trailers per patch

None of the 5 patches has a Reviewed-by or Acked-by.

PatchDaniel Vetter
SeriesRequested-by
1/5Requested-by
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Organize intel_drv.h

From: Paulo Zanoni <[email protected]>

Hi

Daniel reccently complained that we keep adding stuff at the bottom of the file and keep conflicting with each other. So on the first patch I completely reorganize the file so that it lists functions per-file. With this, different patches will mostly only conflict when adding new functions to the same file.

Besides this, patches 2-5 try to remove a few lines from intel_drv.h. All the other functions seem to be either necessary or not trivial to remove.

These patches were written against Friday's tree, and got a simple conflict today. They get bit-rot very quickly and will conflict with everybody else's patches touching the same file. If we don't really want this, please speak :)

Also, feel free to suggest more changes on top of these, and flamewar about the "extern" keywords.

Cheers,
Paulo

Paulo Zanoni (5):
drm/i915: reorganize intel_drv.h
drm/i915: make intel_pipe_has_type static drm/i915: make intel_crtc_load_lut static drm/i915: make intel_crtc_fb_gamma_{set,get} static drm/i915: make hsw_{disable,restore}_lcpll static

 drivers/gpu/drm/i915/intel_display.c | 214 ++++++++----------
 drivers/gpu/drm/i915/intel_drv.h     | 409 ++++++++++++++++++-----------------
 drivers/gpu/drm/i915/intel_fb.c      |  21 ++
 3 files changed, 326 insertions(+), 318 deletions(-)
Signature · 1 line
1.8.3.1