Skip to content

qcow2: Small error path fixes for l2_allocate

Max Reitz qemu-devel 1 version Applied

Status from this message: Thanks, applied all to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3qcow2: Don't put invalid L2 table into cacheblock/qcow2-cluster.c+4 -21 reply
2/3qcow2: Free allocated L2 cluster on errorblock/qcow2-cluster.c+4 -04 replies
3/3qcow2: Always use error path in l2_allocateblock/qcow2-cluster.c+3 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBenoit Canet
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for l2_allocate

Errors in l2_allocate should always go down the error path. If this path is taken, the newly allocated L2 cluster is abandoned and should thus be freed. The L2 table on the other hand should only be put back into the cache if it was taken from it before.

Max Reitz (3):
qcow2: Don't put invalid L2 table into cache
qcow2: Free allocated L2 cluster on error
qcow2: Always use error path in l2_allocate

 block/qcow2-cluster.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.3.1