Skip to content

RFC softirq: Consolidation and stack overrun fix v2

Frederic Weisbecker lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7irq: Force hardirq exit's softirq processing on its own stackkernel/softirq.c+12 -30 replies
2/7irq: Consolidate do_softirq() arch overriden implementationsarch/metag/kernel/irq.c arch/parisc/kernel/irq.c arch/powerpc/kernel/irq.c +8 more+98 -2020 replies
3/7irq: Optimize call to softirq on hardirq exitkernel/softirq.c+1 -10 replies
4/7irq: Improve a bit softirq debuggingkernel/softirq.c+2 -20 replies
5/7irq: Justify the various softirq stack choiceskernel/softirq.c+10 -10 replies
6/7irq: Optimize softirq stack selection in irq exitkernel/softirq.c+10 -42 replies
7/7x86: Tell about irq stack coveragearch/x86/include/asm/irq.h+4 -07 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/7] softirq: Consolidation and stack overrun fix v2

Hi,

So here is a respin after the discussion we had, plus some more goodies:

* 1st patch is a short term pure regression fixe, with stable tag etc...
* 2nd patch now also generalize the softirq_count() check
* 4th improve debugging (just hope I did not mistake the !in_interrupt() assumption in __do_softirq()
* more comments
* introduction of a longer term solution via a new arch symbol for archs to tell about irq_exit() stack coverage.

Thanks.

Frederic Weisbecker (7):
irq: Force hardirq exit's softirq processing on its own stack
irq: Consolidate do_softirq() arch overriden implementations
irq: Optimize call to softirq on hardirq exit
irq: Improve a bit softirq debugging
irq: Justify the various softirq stack choices
irq: Optimize softirq stack selection in irq exit
x86: Tell about irq stack coverage

 arch/metag/kernel/irq.c    | 52 ++++++++++++++++--------------------------
 arch/parisc/kernel/irq.c   | 17 ++------------
 arch/powerpc/kernel/irq.c  | 17 +-------------
 arch/s390/kernel/irq.c     | 52 +++++++++++++++++-------------------------
 arch/sh/kernel/irq.c       | 57 +++++++++++++++++-----------------------------
 arch/sparc/kernel/irq_64.c | 31 ++++++++-----------------
 arch/x86/include/asm/irq.h |  4 ++++
 arch/x86/kernel/entry_64.S |  4 ++--
 arch/x86/kernel/irq_32.c   | 30 +++++++-----------------
 arch/x86/kernel/irq_64.c   | 21 -----------------
 include/linux/interrupt.h  | 11 +++++++++
 kernel/softirq.c           | 40 ++++++++++++++++++++++++--------
 12 files changed, 130 insertions(+), 206 deletions(-)
Signature · 1 line
1.8.3.1