Skip to content

perf tools: Fix scalability problem on callchain merging (v4)

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8perf callchain: Convert children list to rbtreetools/perf/util/callchain.c tools/perf/util/callchain.h+116 -424 replies
2/8perf ui/progress: Add new helper functions for progress bartools/perf/ui/progress.c tools/perf/ui/progress.h tools/perf/util/session.c+40 -120 replies
3/8perf tools: Show progress on histogram collapsingtools/perf/builtin-annotate.c tools/perf/builtin-diff.c tools/perf/builtin-report.c +4 more+20 -80 replies
4/8perf tools: Use an accessor to read thread commtools/perf/builtin-kmem.c tools/perf/builtin-lock.c tools/perf/builtin-sched.c +10 more+39 -320 replies
5/8perf tools: Add time argument on comm settingtools/perf/builtin-top.c tools/perf/builtin-trace.c tools/perf/tests/code-reading.c +7 more+67 -530 replies
6/8perf tools: Add new comm infrastructuretools/perf/Makefile tools/perf/util/comm.c tools/perf/util/comm.h +2 more+202 -290 replies
7/8perf tools: Compare hists comm by addressestools/perf/util/sort.c+2 -10 replies
8/8perf tools: Get current comm instead of last onetools/perf/util/comm.c tools/perf/util/comm.h tools/perf/util/hist.c +4 more+30 -122 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v4)

Hello,

This is a new version of callchain improvement patchset. I found and fixed bugs in the previous version. I verified that it produced exactly same output before and after applying rbtree conversion patch (#1). However after Frederic's new comm infrastructure patches are applied it'd be little different.

The patches are on 'perf/callchain-v4' branch in my tree

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Please test!

Thanks,
Namhyung

Frederic Weisbecker (4):
perf tools: Use an accessor to read thread comm
perf tools: Add time argument on comm setting
perf tools: Add new comm infrastructure
perf tools: Compare hists comm by addresses

Namhyung Kim (4):
perf callchain: Convert children list to rbtree perf ui/progress: Add new helper functions for progress bar perf tools: Show progress on histogram collapsing perf tools: Get current comm instead of last one

 tools/perf/Makefile                                |   2 +
 tools/perf/builtin-annotate.c                      |   2 +-
 tools/perf/builtin-diff.c                          |   2 +-
 tools/perf/builtin-kmem.c                          |   2 +-
 tools/perf/builtin-lock.c                          |   2 +-
 tools/perf/builtin-report.c                        |  10 +-
 tools/perf/builtin-sched.c                         |  16 +--
 tools/perf/builtin-script.c                        |   6 +-
 tools/perf/builtin-top.c                           |   6 +-
 tools/perf/builtin-trace.c                         |  17 +--
 tools/perf/tests/code-reading.c                    |   2 +-
 tools/perf/tests/hists_link.c                      |   8 +-
 tools/perf/ui/browsers/hists.c                     |  10 +-
 tools/perf/ui/progress.c                           |  18 +++
 tools/perf/ui/progress.h                           |  10 ++
 tools/perf/util/callchain.c                        | 147 ++++++++++++++++-----
 tools/perf/util/callchain.h                        |  11 +-
 tools/perf/util/comm.c                             | 121 +++++++++++++++++
 tools/perf/util/comm.h                             |  21 +++
 tools/perf/util/event.c                            |  32 ++---
 tools/perf/util/hist.c                             |   8 +-
 tools/perf/util/hist.h                             |   3 +-
 tools/perf/util/machine.c                          |  39 +++---
 tools/perf/util/machine.h                          |  21 ++-
 .../perf/util/scripting-engines/trace-event-perl.c |   2 +-
 .../util/scripting-engines/trace-event-python.c    |   4 +-
 tools/perf/util/session.c                          |  26 ++--
 tools/perf/util/sort.c                             |  19 ++-
 tools/perf/util/sort.h                             |   1 +
 tools/perf/util/thread.c                           | 103 +++++++++++----
 tools/perf/util/thread.h                           |  10 +-
 31 files changed, 504 insertions(+), 177 deletions(-)
 create mode 100644 tools/perf/util/comm.c
 create mode 100644 tools/perf/util/comm.h
Signature · 1 line
1.7.11.7