Skip to content

Add regulator supply alias

Charles Keepax lkml 3 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am 1381864462-26167-1-git-send-email-ckeepax@opensource.wolfsonmicro.com

Versions newest first · linked by author and title

  1. v2 Latest posting 2/23 patches 6 repliesApplied
  2. v2 posting 1/23 patches 0 repliesSuperseded
  3. v1 RFC1 patch 3 repliesSuperseded

Patches in v2 posting 2/2 Applied

#Subject and filesSizeRepliesApplied
1/3regulator: core: Add ability to create a lookup alias for supplydrivers/regulator/core.c drivers/regulator/devres.c include/linux/regulator/consumer.h+412 -04 replies
2/3mfd: Allow mapping regulator supplies to MFD device from childrendrivers/mfd/mfd-core.c include/linux/mfd/core.h+23 -51 reply
3/3mfd: arizona: Specify supply mappings for Arizona CODECsarch/arm/mach-s3c64xx/mach-crag6410.c drivers/mfd/arizona-core.c+29 -151 reply

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMark Brown
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH 0/3 v2] Add regulator supply alias

This series of patchs adds feature to allow an alias to be created for regulator supply lookup. This aliases will perform the lookup on a different device from that requested by the end user. We also add features into the MFD core to easily map supplies from a child device to the main MFD device.

The main use case for this is when an MFD device is registered as a single node through device tree. It allows frameworks dealing with the individual child drivers to locate their regulators on the main MFD device, without any prior knowledge of its existance. An implementation is given using the arizona driver which has its supplies registered this way through device tree.

This patch series is based on Mark's regulator for-next branch.

One thing I would be interested on improving is the function names they get very long. For example devm_regulator_register_bulk_supply_alias, I would wonder if swapping the register for an add and perhaps swapping supply_alias for just alias would be acceptable? This would give us devm_regulator_get_alias() which is a bit more reasonable in terms of length although perhaps slightly less idiomatic.

Changes from version 1:
- Added bulk and devm versions for all the calls
- Registration of the aliases is added to the MFD framework rather than done in the driver probe

Charles Keepax (3):
regulator: core: Add ability to create a lookup alias for supply
mfd: Allow mapping regulator supplies to MFD device from children
mfd: arizona: Specify supply mappings for Arizona CODECs

 arch/arm/mach-s3c64xx/mach-crag6410.c |   12 ---
 drivers/mfd/arizona-core.c            |   32 ++++++-
 drivers/mfd/mfd-core.c                |   22 ++++-
 drivers/regulator/core.c              |  170 +++++++++++++++++++++++++++++++++
 drivers/regulator/devres.c            |  163 +++++++++++++++++++++++++++++++
 include/linux/mfd/core.h              |    6 +
 include/linux/regulator/consumer.h    |   79 +++++++++++++++
 7 files changed, 464 insertions(+), 20 deletions(-)
Signature · 1 line
1.7.2.5