Skip to content

qcow2: Small error path fixes for snapshot writing

Max Reitz qemu-devel 1 version Applied

Status from this message: Thanks, applied all to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3qcow2: Always use error path on writing snapshotsblock/qcow2-snapshot.c+4 -30 replies
2/3qcow2: Free allocated snapshot table on errorblock/qcow2-snapshot.c+4 -00 replies
3/3qcow2: Assert against snapshot name/ID overflowblock/qcow2-snapshot.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] qcow2: Small error path fixes for snapshot writing

Errors in qcow2_write_snapshots should always go down the error path. If this path is taken, the newly allocated snapshot table clusters are abandoned and should thus be freed.

Furthermore, we should safeguard against a possible future increase of QEMU's maximum snapshot name/ID length.

Max Reitz (3):
qcow2: Always use error path on writing snapshots
qcow2: Free allocated snapshot table on error
qcow2: Assert against snapshot name/ID overflow

 block/qcow2-snapshot.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.3.1