Skip to content

brcmfmac: fixes for MMC hosts without scatter-gather

Arend van Spriel linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12brcmfmac: store address in trace_brcmf_hexdump()drivers/net/wireless/brcm80211/brcmfmac/tracepoint.h+3 -10 replies
2/12brcmfmac: add tracepoint for capturing the SDPCM headerdrivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/tracepoint.h+20 -00 replies
3/12brcmfmac: rename variable max_seg_sz to max_seg_cnt for claritydrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+6 -50 replies
4/12brcmfmac: determine host controller related variables during probedrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+28 -160 replies
5/12brcmfmac: rework scatter-gather code in brcmf_sdio_buffrw()drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+19 -150 replies
6/12brcmfmac: rename brcmf_sdio_buffrw()drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+9 -80 replies
7/12brcmfmac: rework single packet transfersdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+40 -410 replies
8/12brcmfmac: verify result of brcmf_sdio_addrprep() callsdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+11 -40 replies
9/12brcmfmac: remove stale code from brcmf_sdcard_recv_chain()drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+0 -20 replies
10/12brcmfmac: fix brcmf_sdcard_send_pkt() for host without sg supportdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c+11 -30 replies
11/12brcmfmac: fix brcmf_sdio_txpkt_prep() for host without sg supportdrivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c+64 -420 replies
12/12brcmfmac: fix brcmf_sdcard_recv_chain() for host without sg supportdrivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c drivers/net/wireless/brcm80211/brcmfmac/sdio_host.h+21 -40 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchFranky LinHante MeulemanPieter-Paul Giesberts
1/12R-b
2/12R-b R-b R-b
3/12R-b R-b R-b
4/12R-b R-b R-b
5/12R-b R-b R-b
6/12R-b R-b R-b
7/12R-b R-b R-b
8/12R-b R-b R-b
9/12R-b R-b R-b
10/12R-b R-b R-b
11/12R-b R-b R-b
12/12R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/12] brcmfmac: fixes for MMC hosts without scatter-gather

On our internal test setups it turned out that the MMC host controller did not support scatterlists (struct mmc_host::max_segs == 1). It took a number of patches to cleanup and support this. While at it some debug trace functions were modified and added.

Arend van Spriel (12):
brcmfmac: store address in trace_brcmf_hexdump()
brcmfmac: add tracepoint for capturing the SDPCM header
brcmfmac: rename variable max_seg_sz to max_seg_cnt for clarity
brcmfmac: determine host controller related variables during probe
brcmfmac: rework scatter-gather code in brcmf_sdio_buffrw()
brcmfmac: rename brcmf_sdio_buffrw()
brcmfmac: rework single packet transfers
brcmfmac: verify result of brcmf_sdio_addrprep() calls
brcmfmac: remove stale code from brcmf_sdcard_recv_chain()
brcmfmac: fix brcmf_sdcard_send_pkt() for host without sg support
brcmfmac: fix brcmf_sdio_txpkt_prep() for host without sg support
brcmfmac: fix brcmf_sdcard_recv_chain() for host without sg support

 drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c   |  186 +++++++++++---------
 .../net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c |   17 ++
 drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c |  111 +++++++-----
 .../net/wireless/brcm80211/brcmfmac/sdio_host.h    |    6 +-
 .../net/wireless/brcm80211/brcmfmac/tracepoint.h   |   21 ++-
 5 files changed, 216 insertions(+), 125 deletions(-)
Signature · 1 line
1.7.10.4