Skip to content

perf tools: fixes and tweaks

Adrian Hunter lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest11 patches 11 repliesIn review
  2. v214 patches 7 repliesSuperseded
  3. v119 patches 23 repliesSuperseded

Changes in v3 from the cover letter

perf evsel: Always use perf_evsel__set_sample_bit()
New patch
perf evsel: Add missing overflow check
New patch
perf test: Update "sample parsing" test for PERF_SAMPLE_TRANSACTION
New patch
perf evsel: Add missing PERF_SAMPLE_TRANSACTION
New patch

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11perf evsel: Add a debug print if perf_event_open failstools/perf/util/evsel.c+2 -00 replies
2/11perf script: Set up output options for in-stream attributestools/perf/builtin-script.c+48 -160 replies
3/11perf tools: Fix 32-bit cross buildtools/perf/Makefile.perf tools/perf/config/Makefile tools/perf/config/feature-checks/Makefile+4 -40 replies
4/11perf tools: Fix libunwind build and feature detection for 32-bit buildtools/perf/config/Makefile tools/perf/config/feature-checks/Makefile+6 -40 replies
5/11perf evlist: Add a debug print if event buffer mmap failstools/perf/util/evlist.c+2 -00 replies
6/11perf record: Add an option to force per-cpu mmapstools/perf/Documentation/perf-record.txt tools/perf/builtin-record.c tools/perf/util/evlist.c +2 more+14 -311 replies
7/11perf evsel: Always use perf_evsel__set_sample_bit()tools/perf/util/evsel.c+3 -30 replies
8/11perf evsel: Add missing overflow checktools/perf/util/evsel.c+1 -00 replies
9/11perf test: Update "sample parsing" test for PERF_SAMPLE_TRANSACTIONtools/perf/tests/sample-parsing.c+6 -10 replies
10/11perf evsel: Add missing PERF_SAMPLE_TRANSACTIONtools/perf/util/evsel.c+8 -00 replies
11/11perf tools: Allow non-matching sample typestools/perf/builtin-trace.c tools/perf/perf.h tools/perf/util/event.h +3 more+48 -10 replies

Reviews trailers per patch

2 of 11 patches have a Reviewed-by or Acked-by.

PatchJiri OlsaPeter Zijlstra
1/11
2/11
3/11
4/11A-b
5/11
6/11A-b A-b
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH V3 00/11] perf tools: fixes and tweaks

Hi

Here are some fixes and tweaks (version 3) for perf tools.

Changes in V3:
perf evsel: Always use perf_evsel__set_sample_bit()
New patch
perf evsel: Add missing overflow check
New patch
perf test: Update "sample parsing" test for PERF_SAMPLE_TRANSACTION
New patch
perf evsel: Add missing PERF_SAMPLE_TRANSACTION
New patch

Patches dropped because they have been applied:
perf tools: Fix non-debug build
perf inject: Do not repipe attributes to a perf.data file

Changes in V2:

perf tools: Fix non-debug build
New patch
perf evsel: Add a debug print if perf_event_open fails
Unchanged
perf script: Make perf_script a local variable
Split from "perf script: Set up output options for in-stream attributes"
perf script: Set up output options for in-stream attributes
Split out "perf script: Make perf_script a local variable"
perf inject: Do not repipe attributes to a perf.data file
Unchanged
perf tools: Fix 32-bit cross build
Pass only EXTRA_CFLAGS
perf tools: Fix libunwind build and feature detection for 32-bit build
Add Jiri's Ack
perf evlist: Add a debug print if event buffer mmap fails
Add errno
perf tools: Allow non-matching sample types
Suppress compatible sample types for trace tool
perf sched: Make struct perf_sched sched a local variable
New patch
perf sched: Fix optimized build time
New patch
perf tools: Do not accept parse_tag_value() overflow
New patch
perf tools: Validate that mmap_pages is not too big
New patch

Patches dropped because they have been applied:
perf evsel: Add missing 'mmap2' from debug print perf record: Improve write_output error message perf evsel: Add missing decrement in id sample parsing perf session: Add missing sample flush for piped events perf session: Add missing members to perf_event__attr_swap() perf evlist: Fix 32-bit build error
perf tools: Fix test_on_exit for 32-bit build perf tools: Fix bench/numa.c for 32-bit build perf tools: fix perf_evlist__mmap comments
perf tools: factor out duplicated evlist mmap code perf script: print addr by default for BTS

Adrian Hunter (11):
perf evsel: Add a debug print if perf_event_open fails perf script: Set up output options for in-stream attributes perf tools: Fix 32-bit cross build
perf tools: Fix libunwind build and feature detection for 32-bit build perf evlist: Add a debug print if event buffer mmap fails perf record: Add an option to force per-cpu mmaps
perf evsel: Always use perf_evsel__set_sample_bit()
perf evsel: Add missing overflow check
perf test: Update "sample parsing" test for PERF_SAMPLE_TRANSACTION perf evsel: Add missing PERF_SAMPLE_TRANSACTION
perf tools: Allow non-matching sample types

 tools/perf/Documentation/perf-record.txt  |  6 +++
 tools/perf/Makefile.perf                  |  2 +-
 tools/perf/builtin-record.c               |  2 +
 tools/perf/builtin-script.c               | 64 +++++++++++++++++++++++--------
 tools/perf/builtin-trace.c                |  1 +
 tools/perf/config/Makefile                |  8 ++--
 tools/perf/config/feature-checks/Makefile |  6 +--
 tools/perf/perf.h                         |  1 +
 tools/perf/tests/sample-parsing.c         |  7 +++-
 tools/perf/util/event.h                   | 16 ++++++++
 tools/perf/util/evlist.c                  | 31 ++++++++++++++-
 tools/perf/util/evlist.h                  |  1 +
 tools/perf/util/evsel.c                   | 21 +++++++---
 tools/perf/util/record.c                  |  5 ++-
 tools/perf/util/target.h                  |  1 +
 15 files changed, 141 insertions(+), 31 deletions(-)

Regards
Adrian