Skip to content

Clean up open CLAIM_PREVIOUS code path

Weston Andros Adamson linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5NFSv4: fix NULL dereference in open recoverfs/nfs/nfs4proc.c+2 -11 reply
2/5NFSv4: don't fail on missing fattr in open recoverfs/nfs/nfs4proc.c+0 -60 replies
3/5NFSv4: clean up state ref counting in open recoverfs/nfs/nfs4proc.c+8 -55 replies
4/5NFSv4: don't reprocess cached open CLAIM_PREVIOUSfs/nfs/nfs4proc.c+13 -42 replies
5/5NFSv4: clean up nfs4_state reference countingfs/nfs/nfs4proc.c fs/nfs/nfs4state.c+8 -32 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchWeston Andros Adamson
1/5
2/5
3/5A-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Clean up open CLAIM_PREVIOUS code path

My original patch was to just fix the NULL dereference, but Trond noticed some other problems in _nfs4_opendata_reclaim_to_nfs4_state, so I went ahead and fixed them.

I separated this into multiple patches for increased bisectability and made sure the NULL dereference patch was first so that stable@ / distros can choose to just fix the crash if they wish.

I went a bit further than the issues Trond raised with the last patch, but I think it's good for consistency and catching reference counting bugs as errors and not BUG()s.

-dros

Weston Andros Adamson (5):
NFSv4: fix NULL dereference in open recover
NFSv4: don't fail on missing fattr in open recover
NFSv4: clean up state ref counting in open recover
NFSv4: don't reprocess cached open CLAIM_PREVIOUS
NFSv4: clean up nfs4_state reference counting

 fs/nfs/nfs4proc.c  | 39 +++++++++++++++++++++++++--------------
 fs/nfs/nfs4state.c |  3 ++-
 2 files changed, 27 insertions(+), 15 deletions(-)
Signature · 1 line
1.7.12.4 (Apple Git-37)