Skip to content

mountd: disabling turning off TCP listeners (v2)

Steve Dickson linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mountd: Use protocol bit fields to turn protocols off.support/include/rpcmisc.h support/nfs/rpcmisc.c support/nfs/svc_create.c +1 more+21 -70 replies
2/3mountd: Deprecate the ability to disable TCP listeners.utils/mountd/mountd.c utils/mountd/mountd.man+7 -70 replies
3/3mountd: Add the ability to disable UDP listeners.support/nfs/svc_create.c utils/mountd/mountd.c utils/mountd/mountd.man+10 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] mountd: disabling turning off TCP listeners (v2)

[ Here is the second try for these patches incorporating the code review..]

Recently it was pointed out to me that the [-n | --no-tcp] flags were broken in mountd. Sure enough they are and they broke when nfs-utils moved to using libtirpc, which was years ago.

Obviously nobody is using these flags since has not been notice until now, but it seemed to me it no longer makes any sense to have flags. We really want people to use TCP so why should there be a way to turn it off? It should be the opposite... They should be able to turn off UDP listeners not TCP...

Steve Dickson (3):
mountd: Use protocol bit fields to turn protocols off.
mountd: Deprecate the ability to disable TCP listeners.
mountd: Add the ability to disable UDP listeners.

 support/include/rpcmisc.h |  2 +-
 support/nfs/rpcmisc.c     | 19 ++++++++++++++-----
 support/nfs/svc_create.c  |  5 +++++
 utils/mountd/mountd.c     | 17 ++++++++++++-----
 utils/mountd/mountd.man   |  6 +++---
 5 files changed, 35 insertions(+), 14 deletions(-)
Signature · 1 line
1.8.3.1