Skip to content

add gadget quirk to adapt f_fs for DWC3

David Cohen lkml 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest5 patches 6 repliesIn review
  2. v65 patches 4 repliesSuperseded
  3. v55 patches 8 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v44 patches17 repliesSuperseded
v33 patches8 repliesSuperseded
v23 patches7 repliesSuperseded

Changes in v7 from the cover letter

- Downgraded patch set version to v5 as per Felipe Balbi request, with some changes:
- usb_ep_align_maxpacketsize() macro was change to usp_ep_align_maybe()

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5usb: gadget: move bitflags to the end of usb_gadget structinclude/linux/usb/gadget.h+10 -90 replies
2/5usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadgetinclude/linux/usb/gadget.h+20 -06 replies
3/5usb: gadget: f_fs: remove loop from I/O functiondrivers/usb/gadget/f_fs.c+40 -540 replies
4/5usb: f_fs: check quirk to pad epout buf size when not aligned to maxpacketsizedrivers/usb/gadget/f_fs.c+19 -40 replies
5/5usb: dwc3: set gadget's quirk ep_out_align_sizedrivers/usb/dwc3/gadget.c+6 -00 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchMichal Nazarewicz
1/5A-b
2/5A-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/5] add gadget quirk to adapt f_fs for DWC3

Hi,

These patches are a proposal to add gadget quirks in an immediate objective to adapt f_fs when using DWC3 controller. But the quirk solution is generic and can be used by other controllers to adapt gadget functions to their non-standard restrictions.

This change is necessary to make Android's adbd service to work on Intel Merrifield with f_fs instead of out-of-tree android gadget.

This new patch set was tested and validated in my environment:
- Intel Merrifield was able to use DWC3/f_fs with adbd service (it wasn't before).

Changes from v6 to v7:
- Downgraded patch set version to v5 as per Felipe Balbi request, with some changes:
- usb_ep_align_maxpacketsize() macro was change to usp_ep_align_maybe()

     in order to check gadget->quirk_ep_out_aligned_size internally.

- updated patch 4/5 to use new macro usp_ep_align_maybe() and to fix
following compilation warning:
$ drivers/usb/gadget/f_fs.c: In function 'ffs_epfile_io':
$ drivers/usb/gadget/f_fs.c:857:124: warning: comparison of distinct pointer types lacks a cast [enabled by default]

---
David Cohen (3):
usb: gadget: move bitflags to the end of usb_gadget struct
usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget
usb: dwc3: set gadget's quirk ep_out_align_size

Michal Nazarewicz (2):
usb: gadget: f_fs: remove loop from I/O function
usb: f_fs: check quirk to pad epout buf size when not aligned to
maxpacketsize

 drivers/usb/dwc3/gadget.c  |   6 +++
 drivers/usb/gadget/f_fs.c  | 115 +++++++++++++++++++++++----------------------
 include/linux/usb/gadget.h |  39 +++++++++++----
 3 files changed, 94 insertions(+), 66 deletions(-)
Signature · 1 line
1.8.4.2