Skip to content

Report Redesign

Alexandra Yates powertop 3 versions – In review

Get series with b4
b4 am 1384806442-20294-1-git-send-email-alexandra.yates@linux.intel.com

Versions newest first · linked by author and title

  1. v3 Latest31 patches 13 repliesIn review
  2. v231 patches 3 repliesSuperseded
  3. v129 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/31report-formater-html: add logoPowerTop.png src/report/report-formatter-html.cpp src/report/report-formatter-html.h+23 -00 replies
2/31report: call powertop logosrc/report/report-formatter.h src/report/report-maker.cpp src/report/report-maker.h+31 -00 replies
3/31html-report: add title and div tagssrc/report/report-data-html.h src/report/report-formatter-html.cpp src/report/report-formatter-html.h+43 -10 replies
4/31report: report maker add title and divsrc/report/report-formatter.h src/report/report-maker.cpp src/report/report-maker.h+24 -00 replies
5/31report-csv: title, div, logo, headersrc/report/report-formatter-csv.cpp src/report/report-formatter-csv.h+47 -00 replies
6/31report-html: summary list and navigationsrc/report/report-formatter-html.cpp src/report/report-formatter-html.h+20 -02 replies
7/31report-maker: navigation & summarysrc/report/report-formatter.h src/report/report-maker.cpp src/report/report-maker.h+18 -10 replies
8/31report-csv: Added navigation & summary listsrc/report/report-formatter-csv.cpp src/report/report-formatter-csv.h+25 -30 replies
9/31report-html: Table generationsrc/report/report-data-html.h src/report/report-formatter-html.cpp src/report/report-formatter-html.h+79 -72 replies
10/31report-maker: modular table generationsrc/report/report-formatter.h src/report/report-maker.cpp src/report/report-maker.h+12 -00 replies
11/31report-csv: modular tablesrc/report/report-formatter-csv.cpp src/report/report-formatter-csv.h+30 -00 replies
12/31report: Logo and system Informationsrc/Makefile.am src/report/report-data-html.cpp src/report/report-data-html.h +8 more+100 -590 replies
13/31report-html-css: html 5 and css for new designsrc/powertop.css+86 -1300 replies
14/31report-summary: enable html and csv new stylessrc/process/do_process.cpp src/report/report-data-html.cpp src/report/report-data-html.h +1 more+118 -460 replies
15/31report: redesign html menusrc/powertop.css+28 -290 replies
16/31report: CPU Idle section redesigned html & csvsrc/cpu/cpu.cpp src/report/report-data-html.cpp src/report/report-data-html.h+187 -580 replies
17/31report: Fixed html summary & menu colapse stylessrc/powertop.css src/process/do_process.cpp src/report/report-formatter-html.cpp+3 -20 replies
18/31report: CPU Frequency html & csvsrc/cpu/cpu.cpp+101 -385 replies
19/31report: redesign Software Information csv and htmlsrc/process/do_process.cpp src/report/report-data-html.cpp src/report/report-data-html.h+77 -491 reply
20/31report: redesign Device Power Report csv & htmlsrc/devices/device.cpp+35 -370 replies
21/31report: Redesign Device Activity csv & html reportsrc/devices/device.cpp src/devlist.cpp+31 -160 replies
22/31report: cleanup csv title and unused varssrc/report/report-formatter-csv.cpp src/report/report.cpp+2 -20 replies
23/31report: report tuning with new desig html & csvsrc/report/report-data-html.cpp src/report/report-data-html.h src/tuning/tuning.cpp+86 -500 replies
24/31report-html: fixed not hidding sections errorssrc/devices/device.cpp src/devlist.cpp src/powertop.css +3 more+28 -200 replies
25/31report: fixed empty SW settings in need of tunningsrc/tuning/tuning.cpp+35 -250 replies
26/31report: design batery discharge/system baselinesrc/devices/device.cpp+23 -10 replies
27/31report: conditional runs ncurses & cpu html reportsrc/main.cpp+4 -30 replies
28/31report: logo size & menu compatibilitysrc/powertop.css src/report/report-formatter-html.cpp+4 -30 replies
29/31tunables: removed on-demand cpu frequency governorsrc/Makefile.am src/tuning/cpufreq.cpp src/tuning/cpufreq.h +1 more+2 -2672 replies
30/31report-cleanup: removed old table, row, & cell.src/report/report-formatter-csv.cpp src/report/report-formatter-csv.h src/report/report-formatter-html.cpp +4 more+6 -5220 replies
31/31report-cleanup: removed html & csv old methodssrc/report/report-formatter-csv.cpp src/report/report-formatter-csv.h src/report/report-formatter-html.cpp +5 more+21 -3690 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [Powertop] [PATCH v3 00/31] Report Redesign

This patches are to be applied post release 2.5.

This set of patches include the redesign changes for HTML and CSV reports and cleans up unused reporting functions. Additionally, removes the suggestion to use on demand CPU frequency governor. This feature was removed because the Intel P-States driver is the Intel recommended method for CPU frequency.

Igor Zhbanov reported that the localization macro __(…) was left out from previous version. These patches changed to add the localization macro to all report components.

Alexandra Yates (31):
report-formater-html: add logo
report: call powertop logo
html-report: add title and div tags
report: report maker add title and div
report-csv: title, div, logo, header
report-html: summary list and navigation
report-maker: navigation & summary
report-csv: Added navigation & summary list
report-html: Table generation
report-maker: modular table generation
report-csv: modular table
report: Logo and system Information
report-html-css: html 5 and css for new design
report-summary: enable html and csv new styles
report: redesign html menu
report: CPU Idle section redesigned html & csv
report: Fixed html summary & menu colapse styles
report: CPU Frequency html & csv
report: redesign Software Information csv and html
report: redesign Device Power Report csv & html
report: Redesign Device Activity csv & html report
report: cleanup csv title and unused vars
report: report tuning with new desig html & csv
report-html: fixed not hidding sections errors
report: fixed empty SW settings in need of tunning
report: design batery discharge/system baseline
report: conditional runs ncurses & cpu html report
report: logo size & menu compatibility
tunables: removed on-demand cpu frequency governor
report-cleanup: removed old table, row, & cell.
report-cleanup: removed html & csv old methods

 PowerTop.png                         |  Bin 0 -> 6975 bytes
 src/Makefile.am                      |    5 +-
 src/cpu/cpu.cpp                      |  327 ++++++++++++++++++--------
 src/devices/device.cpp               |   81 ++++---
 src/devlist.cpp                      |   44 ++--
 src/main.cpp                         |    7 +-
 src/powertop.css                     |  287 ++++++++++-------------
 src/process/do_process.cpp           |  233 +++++++++++--------
 src/report/report-data-html.cpp      |  118 ++++++++++
 src/report/report-data-html.h        |   69 ++++++
 src/report/report-formatter-csv.cpp  |  189 ++++++---------
 src/report/report-formatter-csv.h    |   42 ++--
 src/report/report-formatter-html.cpp |  417 +++++++++-------------------------
 src/report/report-formatter-html.h   |   71 ++----
 src/report/report-formatter.h        |   32 +--
 src/report/report-maker.cpp          |  180 ++-------------
 src/report/report-maker.h            |  114 ++--------
 src/report/report.cpp                |   83 ++++---
 src/tuning/cpufreq.cpp               |  213 -----------------
 src/tuning/cpufreq.h                 |   50 ----
 src/tuning/tuning.cpp                |  131 ++++++-----
 21 files changed, 1142 insertions(+), 1551 deletions(-)
 create mode 100644 PowerTop.png
 create mode 100644 src/report/report-data-html.cpp
 create mode 100644 src/report/report-data-html.h
 delete mode 100644 src/tuning/cpufreq.cpp
 delete mode 100644 src/tuning/cpufreq.h
Signature · 1 line
1.7.9.5