Skip to content

Broadwell kernel driver support

Ben Widawsky intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest62 patches 63 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/62drm/i915/bdw: IS_GEN8 definitiondrivers/gpu/drm/i915/i915_drv.h+1 -00 replies
2/62drm/i915/bdw: Handle forcewake for writes on gen8drivers/gpu/drm/i915/intel_uncore.c+52 -12 replies
3/62drm/i915/bdw: Disable PPGTT for nowdrivers/gpu/drm/i915/i915_gem_gtt.c+2 -01 reply
4/62drm/i915/bdw: Add device IDsdrivers/gpu/drm/i915/i915_drv.c include/drm/i915_pciids.h+48 -19 replies
5/62drm/i915/bdw: Fences on gen8 look just like gen7drivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_gpu_error.c+2 -00 replies
6/62drm/i915/bdw: Swizzling supportdrivers/gpu/drm/i915/i915_gem.c drivers/gpu/drm/i915/i915_reg.h+4 -01 reply
7/62drm/i915/bdw: HW context supportdrivers/gpu/drm/i915/i915_gem_context.c drivers/gpu/drm/i915/i915_reg.h+6 -00 replies
8/62drm/i915/bdw: Clock gating initdrivers/gpu/drm/i915/intel_pm.c+11 -00 replies
9/62drm/i915/bdw: display stuffdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_sprite.c+3 -11 reply
10/62drm/i915/bdw: support GMS and GGMS changesarch/x86/kernel/early-quirks.c drivers/gpu/drm/i915/i915_gem_gtt.c include/drm/i915_drm.h+42 -31 reply
11/62drm/i915/bdw: Implement interrupt changesdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/i915_reg.h +1 more+473 -121 reply
12/62drm/i915/bdw: Add interrupt info to debugfsdrivers/gpu/drm/i915/i915_debugfs.c+48 -20 replies
13/62drm/i915/bdw: Support 64b relocationsdrivers/gpu/drm/i915/i915_gem_execbuffer.c+31 -10 replies
14/62drm/i915/bdw: dispatch updates (64b related)drivers/gpu/drm/i915/intel_ringbuffer.c+29 -31 reply
15/62drm/i915/bdw: Update MI_FLUSH_DWdrivers/gpu/drm/i915/intel_ringbuffer.c+18 -40 replies
16/62drm/i915/bdw: debugfs updatesdrivers/gpu/drm/i915/i915_debugfs.c+7 -33 replies
17/62drm/i915/bdw: Update relevant error statedrivers/gpu/drm/i915/i915_gpu_error.c+1 -01 reply
18/62drm/i915/bdw: Make gen8_gmch_probedrivers/gpu/drm/i915/i915_gem_gtt.c+68 -242 replies
19/62drm/i915/bdw: Create gen8_gtt_pte_tdrivers/gpu/drm/i915/i915_gem_gtt.c+2 -12 replies
20/62drm/i915/bdw: Add GTT functionsdrivers/gpu/drm/i915/i915_gem_gtt.c+85 -32 replies
21/62drm/i915/bdw: Support BDW cachingdrivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/i915_reg.h+43 -03 replies
22/62drm/i915/bdw: Implement Full Force Miss disablesdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+5 -03 replies
23/62drm/i915/bdw: PPGTT init & cleanupdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_gem_gtt.c+137 -52 replies
24/62drm/i915/bdw: Initialize the PDEsdrivers/gpu/drm/i915/i915_gem_gtt.c+27 -02 replies
25/62drm/i915/bdw: Implement PPGTT clear rangedrivers/gpu/drm/i915/i915_gem_gtt.c+41 -10 replies
26/62drm/i915/bdw: Implement PPGTT insertdrivers/gpu/drm/i915/i915_gem_gtt.c+32 -10 replies
27/62drm/i915/bdw: Implement PPGTT enabledrivers/gpu/drm/i915/i915_gem_gtt.c+50 -02 replies
28/62drm/i915/bdw: unleash PPGTTdrivers/gpu/drm/i915/i915_gem_execbuffer.c drivers/gpu/drm/i915/i915_gem_gtt.c drivers/gpu/drm/i915/intel_ringbuffer.c+6 -40 replies
29/62drm/i915/bdw: Render ring flushingdrivers/gpu/drm/i915/intel_ringbuffer.c+42 -00 replies
30/62drm/i915/bdw: BSD init for gen8 alsodrivers/gpu/drm/i915/intel_ringbuffer.c+1 -10 replies
31/62drm/i915/bdw: Don't muck with gtt_size on Gen8 when PPGTT setup failsdrivers/gpu/drm/i915/i915_gem_gtt.c+2 -10 replies
32/62drm/i915/bdw: ppgtt info in debugfsdrivers/gpu/drm/i915/i915_debugfs.c+42 -70 replies
33/62drm/i915/bdw: add IS_BROADWELL macrodrivers/gpu/drm/i915/i915_drv.h+1 -00 replies
34/62drm/i915/bdw: Broadwell has 3 pipesdrivers/gpu/drm/i915/i915_drv.c+2 -20 replies
35/62drm/i915/bdw: add Broadwell sprite/plane/cursor checksdrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_sprite.c+3 -30 replies
36/62drm/i915/bdw: Broadwell also has the "power down well"drivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/intel_pm.c+8 -33 replies
37/62drm/i915/bdw: pretend we have LPT LP on Broadwelldrivers/gpu/drm/i915/i915_drv.c+6 -01 reply
38/62drm/i915/bdw: get the correct LCPLL frequency on Broadwelldrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_ddi.c+21 -71 reply
39/62drm/i915/bdw: on Broadwell, the panel fitter is on the pipedrivers/gpu/drm/i915/intel_ddi.c+7 -51 reply
40/62drm/i915/bdw: Broadwell has PIPEMISCdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c+43 -21 reply
41/62drm/i915/bdw: Use pipe CSC on Broadwelldrivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_sprite.c+2 -20 replies
42/62drm/i915/bdw: Implement WaSwitchSolVfFArbitrationPrioritydrivers/gpu/drm/i915/intel_pm.c+3 -03 replies
43/62drm/i915/bdw: Add BDW DDI buffer translation valuesdrivers/gpu/drm/i915/intel_ddi.c+47 -51 reply
44/62drm/i915/bdw: add BDW DDI buf translations for eDPdrivers/gpu/drm/i915/intel_ddi.c+33 -51 reply
45/62drm/i915/bdw: add support for BDW DP voltage swings and pre-emphasisdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_dp.c+63 -33 replies
46/62drm/i915/bdw: BDW also has only 2 FDI lanesdrivers/gpu/drm/i915/intel_display.c+1 -10 replies
47/62drm/i915/bdw: check DPD on port D when setting the DDI buffersdrivers/gpu/drm/i915/intel_ddi.c+6 -11 reply
48/62drm/i915/bdw: Add Broadwell display FIFO limitsdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+25 -92 replies
49/62drm/i915/bdw: Use The GT mailbox for IPS enable/disabledrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_display.c+28 -111 reply
50/62drm/i915/bdw: Support eDP PSRdrivers/gpu/drm/i915/i915_drv.h drivers/gpu/drm/i915/i915_reg.h+3 -34 replies
51/62drm/i915/bdw: Use HSW formula for ring freq scalingdrivers/gpu/drm/i915/intel_pm.c+4 -11 reply
52/62drm/i915/bdw: Don't wait for c0 threads on forcewakedrivers/gpu/drm/i915/intel_uncore.c+2 -11 reply
53/62drm/i915/bdw: Broadwell has a max port clock of 300Mhz on HDMIdrivers/gpu/drm/i915/intel_hdmi.c+1 -11 reply
54/62drm/i915/bdw: Create a separate BDW rps enabledrivers/gpu/drm/i915/intel_pm.c+75 -01 reply
55/62drm/i915/bdw: Disable semaphoresdrivers/gpu/drm/i915/i915_drv.c+6 -02 replies
56/62drm/i915/bdw: Implement edp PSR workaroundsdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+23 -02 replies
57/62drm/i915/bdw: BWGTLB clock gate disabledrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+3 -01 reply
58/62drm/i915/bdw: Disable centroid pixel perf optimizationdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+5 -03 replies
59/62drm/i915/bdw: Sampler power bypass disabledrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+3 -00 replies
60/62drm/i915/bdw: Limit SDE poly depth FIFO to 2drivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+4 -00 replies
61/62drm/i915/bdw: conservative SBE VUE cache modedrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+5 -00 replies
62/62drm/i915/bdw: WaSingleSubspanDispatchOnAALinesAndPointsdrivers/gpu/drm/i915/i915_reg.h drivers/gpu/drm/i915/intel_pm.c+4 -00 replies

Reviews trailers per patch

40 of 62 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDamien LespiauVille SyrjäläImre DeakBen WidawskyJani NikulaArt RunyanJesse BarnesMika KuoppalaPaulo ZanoniTodd Previte
SeriesR-b
1/62R-b
2/62
3/62
4/62R-b
5/62R-b
6/62R-b
7/62
8/62
9/62
10/62
11/62
12/62
13/62
14/62
15/62R-b
16/62
17/62R-b
18/62R-b
19/62R-b
20/62R-b
21/62R-b
22/62R-b
23/62R-b R-b
24/62R-b R-b R-b R-b
25/62R-b
26/62R-b
27/62R-b R-b R-b R-b
28/62R-b
29/62R-b R-b
30/62
31/62R-b
32/62
33/62
34/62
35/62R-b
36/62
37/62R-b
38/62R-b
39/62R-b
40/62R-b
41/62R-b
42/62
43/62R-b
44/62R-b R-b
45/62R-b R-b
46/62R-b
47/62R-b R-b
48/62R-b
49/62R-b R-b
50/62R-b R-b R-b R-b R-b R-b
51/62
52/62R-b
53/62R-b R-b
54/62R-b
55/62R-b
56/62R-b
57/62R-b
58/62R-b
59/62
60/62
61/62
62/62

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 10 reviewers.

Read the v1 thread

Cover letter [PATCH 00/62] Broadwell kernel driver support

It is my honor and privilege to submit basic Broadwell support on behalf of Intel.

The patch series includes support for Broadwell which should bring it up to feature parity with Haswell. As you'll note, the patches have received some revisions and review already. This is due to our new process (more on this below). We will be rolling out the new Broadwell goodness over time.

Broadwell represents the next generation (GEN8) in Intel graphics processing hardware. Broadwell graphics bring some of the biggest changes we've seen on the execution and memory management side of the GPU. (There are equally large and exciting changes for the userspace drivers.)

My request to reviewers is: I haven't touched these much at all since submitting to the internal mailing list. Most changes are due to rebase. Try to keep bikesheds to a minimum. We want to try to get this code in the 3.13 kernel, so we have a nice base to actually stabilize and improve features for the 3.14 release. Remember, we have that handy 'preliminary hardware support' to allow people to opt-in to this early enabling code. So I'm shooting for stable "end-userable" BDW code in 3.14.

Note that the last few workarounds likely won't be needed, but I think we can include them until we know for sure otherwise.

Aside from the usual set of things we need to update when simply enabling a new platform, What follows are some of the major changes from HSW->BDW:

* There is no longer a forcewake write FIFO. *Most* writes must explicitly wake the GPU.

* Interrupt registers have been completely reorganized.

* PTEs format and cachability settings have changed to more resemble x86 PTEs, and PAT
* Address space increases, and as such many commands require changing

* Page table structures have changed for the Per Process GTT. The new structure more resembles traditional page tables with registers defining page directory base.

The latter two changes were the real challenge in enabling the platform and getting things to actually work - though in hindsight, they seem so trivial :-)

You may find these patches here:
http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=broadwell

I'll be posting patches for libdrm, and intel-gpu-tools in the next day or two. They are also ready to go, I just need to do a quick once over. At this point, feel free to stop reading.

I wanted to talk a bit about some of the changes on the development side which are enabling us to get code out way before silicon ships. Again, I'd like to point out that the amount of changes on BDW dwarfs any other silicon iteration during my tenure, and certainly can compete with the likes of the gen3->gen4 changes.

Broadwell development for the i915 driver began last November, 2012. With the help of some awesome people we managed to enable a simulation environment for Linux graphics development. While this was not the first time the OTC teams had used simulation for development, it did mark the first time we were using it to simulate and run the entire software stack and model most of the HW. The previous use of simulation really didn't provide anything useful for the kernel driver, and faked enough of the relevant user space interactions to cause some worry.

Another new process was the invention and usage of an internal mailing list, where we could talk about, and review code that we did not yet have permission to open source.

Sometime around mid December, we had code which could run glxgears. The magic is really what happened after. For the last 10 months (give or take), Daniel Vetter has been maintaining our internal repository for development. Providing continuous rebases on the very fast based upstream tree (and less rapid internal development). In addition, we've gotten support from our QA team to test our code internally on the simulator. We've even gotten other groups in Intel (outside of OTC) to contribute to all parts of the stack.

For the foreseeable future, all future platforms will follow this same enabling procedure that allows us to get better, more stable code, well before silicon ships. The goal is to get stable drivers in the kernel release that coincides with the time silicon ships.

As such, a quick thanks:
* Daniel Vetter, for the incredible job he did on maintaining our internal repository.

* Chris Wilson, for getting me a mostly functional DDX within days of a working kernel - for that oh so cool glxgears screenshot.

* Ken Graunke, for actually making mesa work with the absurd amount of changes on the EUs. (and therefore, also enabling said screenshot).

* The Intel internal simulation team, for helping to provide us the necessary tools to make it all happen.

* The Intel [Windows] graphics team, for providing support, and easing the process for open source approval

Art Runyan (1):
drm/i915/bdw: Add BDW DDI buffer translation values

Ben Widawsky (44):
drm/i915/bdw: IS_GEN8 definition
drm/i915/bdw: Handle forcewake for writes on gen8 drm/i915/bdw: Add device IDs
drm/i915/bdw: Fences on gen8 look just like gen7 drm/i915/bdw: Swizzling support
drm/i915/bdw: HW context support
drm/i915/bdw: Clock gating init
drm/i915/bdw: display stuff
drm/i915/bdw: support GMS and GGMS changes drm/i915/bdw: Implement interrupt changes drm/i915/bdw: Add interrupt info to debugfs drm/i915/bdw: Support 64b relocations drm/i915/bdw: dispatch updates (64b related) drm/i915/bdw: Update MI_FLUSH_DW
drm/i915/bdw: debugfs updates
drm/i915/bdw: Update relevant error state drm/i915/bdw: Make gen8_gmch_probe
drm/i915/bdw: Create gen8_gtt_pte_t drm/i915/bdw: Add GTT functions
drm/i915/bdw: Support BDW caching
drm/i915/bdw: Implement Full Force Miss disables drm/i915/bdw: PPGTT init & cleanup
drm/i915/bdw: Initialize the PDEs
drm/i915/bdw: Implement PPGTT clear range drm/i915/bdw: Implement PPGTT insert drm/i915/bdw: Implement PPGTT enable drm/i915/bdw: unleash PPGTT
drm/i915/bdw: Render ring flushing
drm/i915/bdw: BSD init for gen8 also drm/i915/bdw: ppgtt info in debugfs drm/i915/bdw: Implement WaSwitchSolVfFArbitrationPriority drm/i915/bdw: Use The GT mailbox for IPS enable/disable drm/i915/bdw: Support eDP PSR
drm/i915/bdw: Use HSW formula for ring freq scaling drm/i915/bdw: Don't wait for c0 threads on forcewake drm/i915/bdw: Create a separate BDW rps enable drm/i915/bdw: Disable semaphores
drm/i915/bdw: Implement edp PSR workarounds drm/i915/bdw: BWGTLB clock gate disable drm/i915/bdw: Disable centroid pixel perf optimization drm/i915/bdw: Sampler power bypass disable drm/i915/bdw: Limit SDE poly depth FIFO to 2 drm/i915/bdw: conservative SBE VUE cache mode drm/i915/bdw: WaSingleSubspanDispatchOnAALinesAndPoints

Damien Lespiau (2):
drm/i915/bdw: Broadwell has 3 pipes
drm/i915/bdw: Broadwell has a max port clock of 300Mhz on HDMI

Daniel Vetter (1):
drm/i915/bdw: Disable PPGTT for now

Paulo Zanoni (11):
drm/i915/bdw: add IS_BROADWELL macro
drm/i915/bdw: add Broadwell sprite/plane/cursor checks drm/i915/bdw: Broadwell also has the "power down well" drm/i915/bdw: pretend we have LPT LP on Broadwell drm/i915/bdw: get the correct LCPLL frequency on Broadwell drm/i915/bdw: on Broadwell, the panel fitter is on the pipe drm/i915/bdw: Broadwell has PIPEMISC
drm/i915/bdw: add BDW DDI buf translations for eDP drm/i915/bdw: add support for BDW DP voltage swings and pre-emphasis drm/i915/bdw: BDW also has only 2 FDI lanes
drm/i915/bdw: check DPD on port D when setting the DDI buffers

Ville Syrjälä (3):
drm/i915/bdw: Don't muck with gtt_size on Gen8 when PPGTT setup fails drm/i915/bdw: Use pipe CSC on Broadwell
drm/i915/bdw: Add Broadwell display FIFO limits

 arch/x86/kernel/early-quirks.c             |  12 +
 drivers/gpu/drm/i915/i915_debugfs.c        | 109 ++++++-
 drivers/gpu/drm/i915/i915_drv.c            |  34 +-
 drivers/gpu/drm/i915/i915_drv.h            |  36 ++-
 drivers/gpu/drm/i915/i915_gem.c            |   3 +
 drivers/gpu/drm/i915/i915_gem_context.c    |   3 +
 drivers/gpu/drm/i915/i915_gem_execbuffer.c |  35 +-
 drivers/gpu/drm/i915/i915_gem_gtt.c        | 500 +++++++++++++++++++++++++++--
 drivers/gpu/drm/i915/i915_gpu_error.c      |   2 +
 drivers/gpu/drm/i915/i915_irq.c            | 327 +++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h            | 117 ++++++-
 drivers/gpu/drm/i915/intel_ddi.c           | 126 ++++++--
 drivers/gpu/drm/i915/intel_display.c       |  80 ++++-
 drivers/gpu/drm/i915/intel_dp.c            |  55 +++-
 drivers/gpu/drm/i915/intel_hdmi.c          |   2 +-
 drivers/gpu/drm/i915/intel_pm.c            | 168 +++++++++-
 drivers/gpu/drm/i915/intel_ringbuffer.c    | 187 ++++++++++-
 drivers/gpu/drm/i915/intel_sprite.c        |   5 +-
 drivers/gpu/drm/i915/intel_uncore.c        |  56 +++-
 include/drm/i915_drm.h                     |   4 +
 include/drm/i915_pciids.h                  |  27 ++
 21 files changed, 1771 insertions(+), 117 deletions(-)
Signature · 6 lines
1.8.4.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx