Skip to content

random: improve entropy pool initialization at boot time

Theodore Ts'o linux-crypto lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4random: use device attach events for entropydrivers/base/core.c drivers/char/random.c include/linux/random.h+12 -03 replies
2/4random: make add_timer_randomness() fill the nonblocking pool firstdrivers/char/random.c+4 -30 replies
3/4random: printk notifications for urandom pool initializationdrivers/char/random.c+11 -10 replies
4/4random: don't zap entropy count in rand_initialize()drivers/char/random.c+9 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] random: improve entropy pool initialization at boot time

These patches improve how /dev/random initializes its entropy pool during the kernel boot sequence. With these changes, using an x86 test kernel run under KVM, the urandom pool gets initialized before the init scripts start running, and of the kernel users of get_random_bytes(), a debugging printk found only two users of get_random_bytes() before the nonblocking pool could be fully initialized:

rc80211_minstrel_ht_init+0x2b/0x6a called get_random_bytes with 22 bits of entropy available
neigh_hash_alloc+0x82/0x94 called get_random_bytes with 31 bits of entropy available

Both of these calls were in a subsys_initcall(); and the first one I'm fairly certain could be replaced by the use of prandom_u32().

Note: I've cc'ed these patches to linux-crypto so hopefully more people will review these patches.

- Ted

Theodore Ts'o (4):
random: use device attach events for entropy
random: make add_timer_randomness() fill the nonblocking pool first
random: printk notifications for urandom pool initialization
random: don't zap entropy count in rand_initialize()

 drivers/base/core.c    |  3 +++
 drivers/char/random.c  | 42 +++++++++++++++++++++++++++++++-----------
 include/linux/random.h |  2 ++
 3 files changed, 36 insertions(+), 11 deletions(-)
Signature · 1 line
1.7.12.rc0.22.gcdd159b