Skip to content

Giving names to BlockDriverState graph nodes

Benoît Canet qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 20 repliesIn review
  2. v47 patches 30 repliesSuperseded
  3. v3 RFC7 patches 24 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 RFC3 patches0 repliesSuperseded
v12 patches9 repliesSuperseded

Changes in v5 from the cover letter

block empty node names [Kevin]
factorize setting of node-name option [Kevin]
NULL terminate node_name on removal [Kevin]
make query-named-block-nodes return BlockDeviceInfo structure [Eric] Change some doc in query-named-block-nodes [Eric] Document the choice of the QMP API for node name [Eric] Use the same authorization as snapshot on block resize [Kevin] Rebase the series [Kevin]

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7block: Add bs->node_name to hold the name of a bs node of the bs graph.block.c include/block/block.h include/block/block_int.h+52 -151 reply
2/7block: Allow the user to define "node-name" option.block.c+38 -02 replies
3/7qmp: Add a command to list the named BlockDriverState nodes.block.c block/qapi.c blockdev.c +4 more+155 -561 reply
4/7qmp: Allow to change password on named block driver states.block.c blockdev.c hmp.c +3 more+54 -82 replies
5/7block: Create authorizations mechanism for external snapshot and resize.block.c block/blkverify.c blockdev.c +2 more+77 -241 reply
6/7qmp: Allow block_resize to manipulate bs graph nodes.blockdev.c hmp.c qapi-schema.json +1 more+25 -81 reply
7/7qmp: Allow to take external snapshots on bs graphs node.blockdev.c hmp.c qapi-schema.json +1 more+71 -124 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchFam Zheng
1/7R-b
2/7
3/7R-b
4/7R-b
5/7
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH V5 0/7] Giving names to BlockDriverState graph nodes

v5:
block empty node names [Kevin]
factorize setting of node-name option [Kevin]
NULL terminate node_name on removal [Kevin]
make query-named-block-nodes return BlockDeviceInfo structure [Eric] Change some doc in query-named-block-nodes [Eric] Document the choice of the QMP API for node name [Eric] Use the same authorization as snapshot on block resize [Kevin] Rebase the series [Kevin]

Benoît Canet (7):
block: Add bs->node_name to hold the name of a bs node of the bs
graph.
block: Allow the user to define "node-name" option.
qmp: Add a command to list the named BlockDriverState nodes.
qmp: Allow to change password on named block driver states.
block: Create authorizations mechanism for external snapshot and
resize.
qmp: Allow block_resize to manipulate bs graph nodes.
qmp: Allow to take external snapshots on bs graphs node.

 block.c                   | 210 +++++++++++++++++++++++++++++++++++++++++-----
 block/blkverify.c         |   2 +-
 block/qapi.c              | 109 ++++++++++++------------
 blockdev.c                |  93 ++++++++++++++++----
 hmp.c                     |   8 +-
 include/block/block.h     |  23 +++--
 include/block/block_int.h |  21 ++++-
 include/block/qapi.h      |   1 +
 qapi-schema.json          |  48 +++++++++--
 qmp-commands.hx           |  78 ++++++++++++++++-
 10 files changed, 471 insertions(+), 122 deletions(-)
Signature · 1 line
1.8.3.2