Skip to content

making address spaces 64 bit wide

Michael S. Tsirkin qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 7 repliesIn review
  2. v1 RFC5 patches 2 repliesSuperseded

Changes from v2 from the cover letter

lots of bugfixes if you read v1 you'll have to re-read, although the basic algorithm is still the same minor tweaks suggested by Eric Blake

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7split definitions for exec.c and translate-all.c radix treesexec.c translate-all.c translate-all.h+39 -290 replies
2/7exec: replace leaf with skipexec.c+9 -80 replies
3/7exec: extend skip field to 6 bit, page entry to 32 bitexec.c+6 -60 replies
4/7exec: pass hw address to phys_page_findexec.c+4 -40 replies
5/7exec: memory radix tree page level compressionexec.c+74 -17 replies
6/7exec: make address spaces 64-bit wideexec.c+2 -60 replies
7/7exec: reduce L2_PAGE_SIZEexec.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/7] making address spaces 64 bit wide

At the moment, exec ignores high bits in each address, for efficiency.
This is incorrect: devices can do full 64 bit DMA, it's only the CPU that is limited by target address space. Resolving such addresses can actually corrupt the pagetables, so using full 64 bit addresses is called for.

However, using full 64 bit addresses was clocked at 12% performance hit on a microbenchmark.
To solve, teach pagetables to skip bits at any level
and not just the lowest level.

This solves the performance problem (only one line of code changed on the data path). In fact we even gain a bit of speed:

Before:
portio-no-eventfd:pci-io 3225
After:
portio-no-eventfd:pci-io 3123

Changes from v2:
lots of bugfixes if you read v1 you'll have to re-read, although the basic algorithm is still the same minor tweaks suggested by Eric Blake

Michael S. Tsirkin (5):
exec: replace leaf with skip
exec: extend skip field to 6 bit, page entry to 32 bit
exec: pass hw address to phys_page_find
exec: memory radix tree page level compression
exec: reduce L2_PAGE_SIZE

Paolo Bonzini (2):
split definitions for exec.c and translate-all.c radix trees
exec: make address spaces 64-bit wide

 translate-all.h |   7 ---
 exec.c          | 135 +++++++++++++++++++++++++++++++++++++++++++++-----------
 translate-all.c |  32 ++++++++------
 3 files changed, 127 insertions(+), 47 deletions(-)
Signature · 1 line
MST