Skip to content

input: RMI4 Synaptics RMI4 Touchscreen Driver

Christopher Heiny linux-input 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4input: RMI4 core filesdrivers/input/rmi4/rmi_bus.c drivers/input/rmi4/rmi_bus.h drivers/input/rmi4/rmi_control.h +3 more+827 -7050 replies
2/4input synaptics-rmi4: I2C transport layerdrivers/input/rmi4/rmi_i2c.c+62 -710 replies
3/4input synaptics-rmi4: RMI4 F01 device controldrivers/input/rmi4/rmi_f01.c drivers/input/rmi4/rmi_f01.h+568 -10152 replies
4/4input synaptics-rmi4: RMI4 F11 2D sensingdrivers/input/rmi4/rmi_f11.c drivers/input/rmi4/rmi_f11.h+874 -14610 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchJean Delvare
1/4
2/4A-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/04] input: RMI4 Synaptics RMI4 Touchscreen Driver

This patchset implements changes to the synaptics-rmi4 branch of Dmitry's input tree. The base for the patchset is Dmitry's commit 4a695a01fba9bf467b3b52e124ccee6cef73b323 from 2013-01-31.

Overall this patchset implements the following changes with respect to the Dmitry's 2013-01-31 commit:

* Refactors the transport layer (rmi_i2c) to be named appropriately.

* Eliminates packed struct bitfields, replacing them with masks and shifts. This should make the various register definitions endian-independent.

* Removed most or all of the sysfs and debugfs support from the driver core and function drivers. These features are still critical during platform development, particularly on embedded systems, so there are hooks that allow custom modules that support these control and debug capabilities. One result of this is that several .c files have a corresponding .h file (for example, rmi_f01.c has a corresponding rmi_f01.h). Also, a rmi_control.h file is added to provide general definitions for control/debug modules.

* Fixes a number of bugs in the baseline commit.

* Trivial - added an rmi_version.h file, which lets the version be easily tweaked using a script.

We've broken this patch into 6 parts, as follows:
01 - core sensor and bus implementation
02 - I2C physical layer driver
03..04 - drivers for individual RMI functions

Hopefully this is the last time we'll have wide-ranging structural changes in the driver code, and future patchsets can be much smaller and confined to one or two areas of interest. (yeah, I've said that before...)

Comments and other feedback on this driver are welcomed.

Christopher Heiny and the Synaptics RMI4 driver team

Cc Dmitry Torokhov <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Linus Walleij <[email protected]>
Cc Joerie de Gram <[email protected]>

---