Skip to content

6lowpan: udp compression/uncompression fix

Alexander Aring linux-bluetooth 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 1 replyIn review
  2. v27 patches 3 repliesSuperseded
  3. v12 of 6 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- remove unnecessary casts and brackes, suggested by Werner Almesberger.
- use pr_debug_ratelimited instead of pr_debug on patch 4/7.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/86lowpan: introduce lowpan_push_hc_data functionnet/ieee802154/6lowpan.h+7 -00 replies
2/86lowpan: udp use lowpan_push_hc_data functionnet/ieee802154/6lowpan_iphc.c+20 -170 replies
3/86lowpan: fix udp compress orderingnet/ieee802154/6lowpan_iphc.c+1 -10 replies
4/86lowpan: fix udp byte orderingnet/ieee802154/6lowpan_iphc.c+20 -190 replies
5/86lowpan: add udp warning for elided checksumnet/ieee802154/6lowpan.h net/ieee802154/6lowpan_iphc.c+9 -30 replies
6/86lowpan: udp use lowpan_fetch_skb functionnet/ieee802154/6lowpan_iphc.c+18 -190 replies
7/86lowpan: udp use subtraction on both conditionsnet/ieee802154/6lowpan_iphc.c+1 -10 replies
8/86lowpan: cleanup udp compress functionnet/ieee802154/6lowpan_iphc.c+15 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 bluetooth-next 0/8] 6lowpan: udp compression/uncompression fix

The current 6LoWPAN udp compression/uncompression is completely broken. This patch series fix a lot of udp compression/uncompression issues and add support parsing with lowpan_fetch_skb/lowpan_push_hc_data functions.

I tested it in all cases of compressions in wireshark and a contiki sensornode.

Changes since v3:
- add patch to introduce lowpan_push_hc_data helper function.
- remove patch to fix nullpointer dereferencing and replace it with a patch which use the lowpan_push_hc_data function in compress_udp_header function. This fixes the nullpointer dereferencing problem also and is more readable.
- add missing newline in pr_debug_ratelimited.

Changes since v2:
- remove unnecessary casts and brackes, suggested by Werner Almesberger.
- use pr_debug_ratelimited instead of pr_debug on patch 4/7.

Alexander Aring (8):
6lowpan: introduce lowpan_push_hc_data function
6lowpan: udp use lowpan_push_hc_data function
6lowpan: fix udp compress ordering
6lowpan: fix udp byte ordering
6lowpan: add udp warning for elided checksum
6lowpan: udp use lowpan_fetch_skb function
6lowpan: udp use subtraction on both conditions
6lowpan: cleanup udp compress function

 net/ieee802154/6lowpan.h      |   8 +++
 net/ieee802154/6lowpan_iphc.c | 114 ++++++++++++++++++++++++------------------
 2 files changed, 74 insertions(+), 48 deletions(-)
Signature · 1 line
1.8.5.1