Skip to content

systemd integraion

Hannes Reinecke dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13Improve logging for orphan_path()libmultipath/configure.c libmultipath/structs_vec.c libmultipath/structs_vec.h +1 more+9 -80 replies
2/13Set priority to '0' for PATH_BLOCKED or PATH_DOWNlibmultipath/discovery.c+3 -00 replies
3/13libmultipath: fixup strlcpylibmultipath/util.c+1 -20 replies
4/13libmultipath: return error numbers from sysfs_get_XXXlibmultipath/discovery.c libmultipath/discovery.h libmultipath/propsel.c +1 more+24 -232 replies
5/13libmultipath: do not stall on recv_packet()libmultipath/uxsock.c+16 -10 replies
6/13multipathd: switch to socket activation for systemdlibmultipath/Makefile libmultipath/uxsock.c multipathd/Makefile +4 more+35 -150 replies
7/13multipathd: use sd_notify() to inform systemdmultipathd/main.c multipathd/multipathd.service+8 -20 replies
8/13multipathd: Add option '-s' to suppress timestampslibmultipath/debug.c libmultipath/devmapper.c multipathd/main.c +2 more+32 -210 replies
9/13multipathd: Implement systemd watchdog integrationmultipath/multipath.conf.5 multipathd/main.c multipathd/multipathd.service+20 -33 replies
10/13multipathd: enable core dumps for systemdmultipathd/multipathd.service+1 -00 replies
11/13multipathd: Read environment variables from systemdmultipathd/main.c+11 -10 replies
12/13multipathd: measure path check timemultipathd/main.c+21 -70 replies
13/13multipathd: no_map_shutdown optionlibmultipath/config.h libmultipath/dict.c multipath.conf.annotated +4 more+69 -65 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/13] systemd integraion

Hi all,

this is a patch series for proper systemd integration. Main idea is to have the CLI socket controlled by systemd, so that the daemon will be started automatically if someone calls 'multipathd -kSomething'.
The neat thing with this is that we can use the systemd-provided watchdog to detect stalls in checkerloop(), which always have been bitten us in the past and are really hard to diagnose remotely.
Plus with socket activation we can now safely implement a 'one-shot' mode, where the daemon exits if no maps are discovered. Which means that we can enable the socket always, and don't have to worry about a daemon sitting in the background eating up resources and doing nothing.
Oh. And some general fixes, too.

Hannes Reinecke (13):
Improve logging for orphan_path()
Set priority to '0' for PATH_BLOCKED or PATH_DOWN
libmultipath: fixup strlcpy
libmultipath: return error numbers from sysfs_get_XXX
libmultipath: do not stall on recv_packet()
multipathd: switch to socket activation for systemd
multipathd: use sd_notify() to inform systemd
multipathd: Add option '-s' to suppress timestamps
multipathd: Implement systemd watchdog integration
multipathd: enable core dumps for systemd
multipathd: Read environment variables from systemd
multipathd: measure path check time
multipathd: no_map_shutdown option

 libmultipath/Makefile         |  2 +-
 libmultipath/config.h         |  1 +
 libmultipath/configure.c      |  4 +-
 libmultipath/debug.c          | 17 ++++----
 libmultipath/devmapper.c      | 16 ++++----
 libmultipath/dict.c           | 32 +++++++++++++++
 libmultipath/discovery.c      | 43 +++++++++++---------
 libmultipath/discovery.h      |  2 +-
 libmultipath/propsel.c        |  2 +-
 libmultipath/structs_vec.c    |  9 ++---
 libmultipath/structs_vec.h    |  2 +-
 libmultipath/util.c           |  3 +-
 libmultipath/uxsock.c         | 41 +++++++++++++++++--
 multipath.conf.annotated      |  9 +++++
 multipath/multipath.conf.5    | 14 ++++++-
 multipathd/Makefile           |  4 +-
 multipathd/main.c             | 94 ++++++++++++++++++++++++++++++++++---------
 multipathd/multipathd.8       | 11 ++++-
 multipathd/multipathd.service | 10 +++--
 multipathd/multipathd.socket  |  5 +++
 multipathd/uxclnt.c           |  4 +-
 multipathd/uxlsnr.c           |  4 +-
 22 files changed, 245 insertions(+), 84 deletions(-)
 create mode 100644 multipathd/multipathd.socket
Signature · 1 line
1.8.1.4