Skip to content

Socfpga: clk: trivial fixes and cleanup

Dinh Nguyen linux-arm-kernel 1 version New

Get series with b4
b4 am 1384878090.24993.0.camel@linux-builds1

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup
Quoted 28 lines · Steffen Trumtrar

Hi Dinh!

Quoted 13 lines · Dinh Nguyen

Hi Steffen,

On Tue, Nov 12, 2013 at 1:40 AM, Steffen Trumtrar <[email protected]

Quoted 8 lines

wrote:
I actually also wanted to change the l3_sp_clk, as it seems to be neglect the "1 or 2" divider from l3_mp_clk IIRC, but I couldn't come up with a good
way without changing the binding or something. What do you thing about that?
Is that wrong at the moment or do I miss something?

Quoted 6 lines

Ah yes, the l3_sp_clk's parent should be l3_mp_clk and not mainclk.

Thanks for spotting that...

Dinh

Hm, that doesn't sound right. Don't we currently have Gate+Divider combo in the l3_mp_clk? If you turn off the clock gate from the l3_mp_clk, then l3_sp_clk would also be turned off.
But according to Figure 2-3 in cv_5v4.pdf

Quoted 5 lines
	DIV1 --------> GATE -----> L3_MP_CLK
                 |
		 |---- DIV2 -----> L3_SP_CLK

So, l3_sp_clk's parent is the divider of l3_mp_clk but NOT the gate.

ah, yes. I'll have to dig into this issue a bit more.

Dinh

Quoted 4 lines

Regards,
Steffen