Skip to content

acpi unit-test: added tests

Marcel Apfelbaum qemu-devel 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 12 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5acpi unit-test: load and check facs tabletests/acpi-test.c+18 -01 reply
2/5acpi unit-test: adjust the test data structure for better handlingtests/acpi-test.c+32 -231 reply
3/5acpi unit-test: add test filestests/acpi-test-data/pc/APIC.dsl tests/acpi-test-data/pc/DSDT.dsl tests/acpi-test-data/pc/FACP.dsl +10 more+6956 -03 replies
4/5configure: added acpi unit-test filesconfigure+4 -00 replies
5/5acpi unit-test: compare DSDT and SSDT tables against expected valuestests/acpi-test.c+211 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests

Added 2 tests:
1. Basic check of FACS table (missed on prev submission)
2. Compare DSDT and SSDT tables against expected values

Test 2:
- runs only if iasl is installed on the host machine.
- the test plan:
1. Dumps the ACPI tables as AML on the disk.
2. Runs iasl to disassembly the tables into ASL files.
3. Compares them with expected offline ASL files.

- the test runs for both default machine and q35.
- in case the test fails, it can be easily tweaked to show the differences between the ASL files and understand the issue.

Patches:
1/5 - test 1
2/5 - some infrastructure improvements
3/5 - expected asl files for test 2
4/5 - creates links for the expected files
if the build directory is not current
5/5 - test 2

Marcel Apfelbaum (5):
acpi unit-test: load and check facs table
acpi unit-test: adjust the test data structure for better handling acpi unit-test: add test files
configure: added acpi unit-test files
acpi unit-test: compare DSDT and SSDT tables against expected values

 configure                         |    4 +
 tests/acpi-test-data/pc/APIC.dsl  |  103 ++
 tests/acpi-test-data/pc/DSDT.dsl  | 1870 ++++++++++++++++++++++
 tests/acpi-test-data/pc/FACP.dsl  |   99 ++
 tests/acpi-test-data/pc/FACS.dsl  |   32 +
 tests/acpi-test-data/pc/HPET.dsl  |   43 +
 tests/acpi-test-data/pc/SSDT.dsl  |  634 ++++++++
 tests/acpi-test-data/q35/APIC.dsl |  103 ++
 tests/acpi-test-data/q35/DSDT.dsl | 3197 +++++++++++++++++++++++++++++++++++++
 tests/acpi-test-data/q35/FACP.dsl |   99 ++
 tests/acpi-test-data/q35/FACS.dsl |   32 +
 tests/acpi-test-data/q35/HPET.dsl |   43 +
 tests/acpi-test-data/q35/MCFG.dsl |   36 +
 tests/acpi-test-data/q35/SSDT.dsl |  665 ++++++++
 tests/acpi-test.c                 |  282 +++-
 15 files changed, 7210 insertions(+), 32 deletions(-)
 create mode 100644 tests/acpi-test-data/pc/APIC.dsl
 create mode 100644 tests/acpi-test-data/pc/DSDT.dsl
 create mode 100644 tests/acpi-test-data/pc/FACP.dsl
 create mode 100644 tests/acpi-test-data/pc/FACS.dsl
 create mode 100644 tests/acpi-test-data/pc/HPET.dsl
 create mode 100644 tests/acpi-test-data/pc/SSDT.dsl
 create mode 100644 tests/acpi-test-data/q35/APIC.dsl
 create mode 100644 tests/acpi-test-data/q35/DSDT.dsl
 create mode 100644 tests/acpi-test-data/q35/FACP.dsl
 create mode 100644 tests/acpi-test-data/q35/FACS.dsl
 create mode 100644 tests/acpi-test-data/q35/HPET.dsl
 create mode 100644 tests/acpi-test-data/q35/MCFG.dsl
 create mode 100644 tests/acpi-test-data/q35/SSDT.dsl
Signature · 1 line
1.8.3.1