Skip to content

qemu-img convert optimizations

Peter Lieven qemu-devel 3 versions – Applied

Status from this message: Thanks, applied to my block tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 15 repliesApplied
  2. v29 patches 11 repliesSuperseded
  3. v16 patches 18 repliesSuperseded

Changes in v3 from the cover letter

- added Paolos comments in Patch 1
- changed the comment in patch 7 [Paolo]
- remove the patch to add sector progress output
- added a new patch to decrease the progress update interval.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/9qemu-img: add support for skipping zeroes in input during convertqemu-img.c+42 -384 replies
2/9qemu-img: fix usage instruction for qemu-img convertqemu-img.c+0 -10 replies
3/9block/iscsi: set bdi->cluster_sizeblock/iscsi.c+7 -00 replies
4/9block: add opt_transfer_length to BlockLimitsinclude/block/block_int.h+3 -00 replies
5/9block/iscsi: set bs->bl.opt_transfer_lengthblock/iscsi.c+3 -00 replies
6/9qemu-img: dynamically adjust iobuffer size during convertqemu-img.c+13 -31 reply
7/9qemu-img: round down request length to an aligned sectorqemu-img.c+24 -103 replies
8/9qemu-img: increase min_sparse to 128 sectors (64kb)qemu-img.c qemu-img.texi+3 -35 replies
9/9qemu-img: decrease progress update interval on convertqemu-img.c+1 -10 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchEric BlakePaolo Bonzini
1/9R-b
2/9R-b R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Qemu-devel] [PATCHv3 1.8 0/9] qemu-img convert optimizations

this series adds some optimizations for qemu-img during convert which have been developed recently:
- skipping input based on get_block_status
- variable I/O buffer size
- align write requests to cluster_size

v2->v3:
- added Paolos comments in Patch 1
- changed the comment in patch 7 [Paolo]
- remove the patch to add sector progress output
- added a new patch to decrease the progress update interval.

v1->v2:
- introduce opt_transfer_length in BlockLimits [Paolo]
- remove knobs for iobuffer_size and alignment and use them unconditionally [Paolo]
- calculate I/O buffer size by BlockLimits information [Paolo]
- change the alignment patch to round down to the last and not to the next aligned sector [Paolo]
- limit updates in the sector progress output
- new patch to increase the default for min_sparse [Paolo]

Peter Lieven (9):
qemu-img: add support for skipping zeroes in input during convert
qemu-img: fix usage instruction for qemu-img convert block/iscsi: set bdi->cluster_size
block: add opt_transfer_length to BlockLimits block/iscsi: set bs->bl.opt_transfer_length
qemu-img: dynamically adjust iobuffer size during convert
qemu-img: round down request length to an aligned sector
qemu-img: increase min_sparse to 128 sectors (64kb)
qemu-img: decrease progress update interval on convert

 block/iscsi.c             |   10 ++++
 include/block/block_int.h |    3 ++
 qemu-img.c                |  131 +++++++++++++++++++++++++++------------------
 qemu-img.texi             |    2 +-
 4 files changed, 93 insertions(+), 53 deletions(-)
Signature · 1 line
1.7.9.5