Skip to content

Hook up powerclamp with PM QOS and cpuidle

Jacob Pan linux-pm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pm/qos: allow state control of qos classinclude/linux/pm_qos.h kernel/power/qos.c+33 -15 replies
2/3cpuidle: check for pm qos constraint overridedrivers/cpuidle/governors/ladder.c drivers/cpuidle/governors/menu.c+15 -20 replies
3/3thermal/powerclamp: communicate with pm qos when injecting idledrivers/thermal/intel_powerclamp.c+8 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Hook up powerclamp with PM QOS and cpuidle

This patchset is intended to address the behavior change and efficiency loss introduced by using consolidated idle routine in powerclamp driver.

Specifically,
[PATCH 3/8] idle, thermal, acpi: Remove home grown idle implementations

The motivation is that after using common idle routine, powerclamp driver can no longer pick the deepest idle state needed to conserve power. Idle state is selected by governors which can be influenced by PM QOS and other factors. This patchset hooks up powerclamp idle injection with PM QOS and eventually influce idle governors to pick the power saving target states.

There are some downside of this approach. Due to overhead, communication with PM QOS is at enable/disable idle injection time instead of each injection period. The implication is that if the system natual idle is more than target injected idle, powerclamp will skip some injection period. During this period however, deepest idle state may still be chosen necessarily regardless the latency constraint.

Jacob Pan (3):
pm/qos: allow state control of qos class
cpuidle: check for pm qos constraint override thermal/powerclamp: communicate with pm qos when injecting idle

 drivers/cpuidle/governors/ladder.c |  4 ++++
 drivers/cpuidle/governors/menu.c   | 13 +++++++++++--
 drivers/thermal/intel_powerclamp.c |  8 ++++++++
 include/linux/pm_qos.h             | 10 +++++++++-
 kernel/power/qos.c                 | 24 ++++++++++++++++++++++++
 5 files changed, 56 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1.2