Skip to content

RFC input: rewrite qemu input layer

Gerd Hoffmann qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest15 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15console: export QemuConsole index, width, heightinclude/ui/console.h ui/console.c+27 -00 replies
2/15input: rename file to legacyui/Makefile.objs ui/input-legacy.c+1 -10 replies
3/15input: define event types using qapiqapi-schema.json+29 -02 replies
4/15input: add core bits of the new input layerinclude/ui/input.h ui/Makefile.objs ui/input.c+116 -10 replies
5/15input: keyboard: add helper functions to coreinclude/ui/input.h ui/input.c+22 -00 replies
6/15input: keyboard: switch legacy handlers to new coreui/input-legacy.c+44 -100 replies
7/15input: keyboard: switch qmp_send_key() to new core.ui/input-legacy.c+2 -80 replies
8/15input: keyboard: switch gtk ui to new coreui/gtk.c+4 -150 replies
9/15input: keyboard: switch sdl ui to new core [wip]ui/sdl.c+10 -130 replies
10/15input: mouse: add helpers functions to coreinclude/ui/input.h ui/input.c+85 -00 replies
11/15input: mouse: add graphic_rotate supportui/input.c+33 -02 replies
12/15input: mouse: add qemu_input_is_absolute()include/ui/input.h ui/input.c+9 -01 reply
13/15input: mouse: switch legacy handlers to new coreui/input-legacy.c+63 -00 replies
14/15input: mouse: switch gtk ui to new coreui/gtk.c+19 -390 replies
15/15input: mouse: switch sdl ui to new coreui/sdl.c+34 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Qemu-devel] [RFC PATCH 00/15] input: rewrite qemu input layer

Hi,

This patch series is the first draft of a input layer rewrite. New core code is largely in place. There is some windup for the legacy functions, to keep things working while switching over users one by one.

Some ui code is converted to make clear how the new input layer should be used.

No work on the device emulation side of things yet.

Main motivation for this is multihead support. Thats why QemuConsole is passed everythere, even though the code doesn't use it (yet). But some day the input layer has the should be able to process/route events depending on the source.

Easy monitor integration is on the radar too, even though none if this is coded up yet. I wanna test the data structures more before even thinking about exposing them via qmp.

In general the new way of handling events should more flexible and be easier to extend than the old code we have right now. We might want add touch support for example ...

Reviews? Comments?

cheers,
Gerd

Gerd Hoffmann (15):
console: export QemuConsole index,width,height
input: rename file to legacy
input: define event types using qapi
input: add core bits of the new input layer
input: keyboard: add helper functions to core
input: keyboard: switch legacy handlers to new core
input: keyboard: switch qmp_send_key() to new core.
input: keyboard: switch gtk ui to new core
input: keyboard: switch sdl ui to new core [wip]
input: mouse: add helpers functions to core
input: mouse: add graphic_rotate support
input: mouse: add qemu_input_is_absolute()
input: mouse: switch legacy handlers to new core
input: mouse: switch gtk ui to new core
input: mouse: switch sdl ui to new core

 include/ui/console.h |   3 +
 include/ui/input.h   |  50 ++++
 qapi-schema.json     |  29 +++
 ui/Makefile.objs     |   2 +-
 ui/console.c         |  24 ++
 ui/gtk.c             |  77 ++----
 ui/input-legacy.c    | 650 +++++++++++++++++++++++++++++++++++++++++++++++++++
 ui/input.c           | 627 +++++++++++--------------------------------------
 ui/sdl.c             |  88 +++----
 9 files changed, 965 insertions(+), 585 deletions(-)
 create mode 100644 include/ui/input.h
 create mode 100644 ui/input-legacy.c
Signature · 1 line
1.8.3.1