RFC perf tools: Add perf_evlist errno
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | perf tools: Add perf_evlist error string interfacetools/ tools/ | +47 | 0 replies | |
| 2/6 | perf tools: Add PERF_EVLIST__ERRNO_MMAP internal errortools/ tools/ | +29 | 0 replies | |
| 3/6 | perf tools: Add PERF_EVLIST__ERRNO_OPEN internal errortools/ tools/ tools/ | +45 | 0 replies | |
| 4/6 | perf tools: Add PERF_EVLIST__ERRNO_IOCTL_ID_GROUP internal errortools/ tools/ | +9 | 0 replies | |
| 5/6 | perf tools: Add PERF_EVLIST__ERRNO_NEWTP internal errortools/ tools/ tools/ | +55 | 0 replies | |
| 6/6 | perf tools: Use perf_evlist__strerror in kvm/record/top/trace commandstools/ tools/ tools/ +1 more | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 0/6] perf tools: Add perf_evlist errno
hi,
Andi reported wrong error message for :S modifier on kernel without event ID ioctl support.
The reason was that the ioctl failed, but the error was printed like the mmap would:
$ perf.old record -e '{cycles,cache-misses}:S' ls
failed to mmap with 25 (Inappropriate ioctl for device)
ls: TerminatedI experimentally added sort of 'libc errno' interface for perf_evlist to be able to get proper error message, like:
$ perf record -e '{cycles,cache-misses}:S' ls
Cannot read event group on this kernel.
Please consider kernel update (v3.12+).
ls: TerminatedI'm not sure about this approach. Maybe it'd be better be more global..? So before throwing this out, sending it as RFC ;-)
thanks for ideas,
jirka
---
Jiri Olsa (6):
perf tools: Add perf_evlist error string interface
perf tools: Add PERF_EVLIST__ERRNO_MMAP internal error perf tools: Add PERF_EVLIST__ERRNO_OPEN internal error perf tools: Add PERF_EVLIST__ERRNO_IOCTL_ID_GROUP internal error perf tools: Add PERF_EVLIST__ERRNO_NEWTP internal error perf tools: Use perf_evlist__strerror in kvm/record/top/trace commands
tools/perf/builtin-kvm.c | 2 +- tools/perf/builtin-record.c | 13 +------ tools/perf/builtin-top.c | 3 +- tools/perf/builtin-trace.c | 34 ++++++++--------- tools/perf/util/evlist.c | 205 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------- tools/perf/util/evlist.h | 23 +++++++++++- 6 files changed, 181 insertions(+), 99 deletions(-)