Skip to content

Coverity fixes for libxl

Matthew Daley xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13libxl: fix unsigned less-than-0 comparison in e820_sanitizetools/libxl/libxl_x86.c+1 -13 replies
2/13libxl: check for xc_domain_setmaxmem failure in libxl__build_pretools/libxl/libxl_dom.c+6 -15 replies
3/13libxl: correct file open success check in libxl__device_pci_resettools/libxl/libxl_pci.c+1 -11 reply
4/13libxl: don't leak p in libxl__wait_for_backendtools/libxl/libxl_device.c+3 -08 replies
5/13libxl: remove unsigned less-than-0 comparisontools/libxl/libxl_cpuid.c+1 -11 reply
6/13libxl: actually abort if initializing a ctx's lock failstools/libxl/libxl.c+2 -01 reply
7/13libxl: don't leak output vcpu info on error in libxl_list_vcputools/libxl/libxl.c+7 -31 reply
8/13libxl: don't leak ptr in libxl_list_vm error casetools/libxl/libxl.c+7 -726 replies
9/13libxl: don't leak pcidevs in libxl_pcidev_assignabletools/libxl/libxl_pci.c+3 -41 reply
10/13libxl: don't try to fclose file twice on error in libxl_userdata_storetools/libxl/libxl_dom.c+14 -216 replies
11/13libxl: use pipe instead of temporary file for VNC viewer --autopasstools/libxl/libxl.c+11 -192 replies
12/13libxl: don't leak buf in libxl_xen_console_read_start error handlingtools/libxl/libxl.c+1 -03 replies
13/13libxl: replace for loop with more idiomatic do-while looptools/libxl/libxl.c+2 -52 replies

Reviews trailers per patch

11 of 13 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrew CooperIan JacksonDario Faggioli
SeriesR-b
1/13R-b A-b Committed-by
2/13A-b Committed-by R-b
3/13A-b Committed-by
4/13R-b A-b Committed-by
5/13A-b Committed-by
6/13A-b Committed-by
7/13A-b Committed-by
8/13R-b R-b Committed-by A-b Committed-by
9/13A-b Committed-by
10/13A-b Committed-by
11/13
12/13A-b Committed-by
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/13] Coverity fixes for libxl

Matthew Daley (13):
libxl: fix unsigned less-than-0 comparison in e820_sanitize
libxl: check for xc_domain_setmaxmem failure in libxl__build_pre
libxl: correct file open success check in libxl__device_pci_reset
libxl: don't leak p in libxl__wait_for_backend
libxl: remove unsigned less-than-0 comparison
libxl: actually abort if initializing a ctx's lock fails
libxl: don't leak output vcpu info on error in libxl_list_vcpu
libxl: don't leak ptr in libxl_list_vm error case
libxl: don't leak pcidevs in libxl_pcidev_assignable
libxl: don't try to fclose file twice on error in
libxl_userdata_store
libxl: use pipe instead of temporary file for VNC viewer --autopass
libxl: don't leak buf in libxl_xen_console_read_start error handling
libxl: replace for loop with more idiomatic do-while loop

 tools/libxl/libxl.c        |   64 +++++++++++++++++++++-----------------------
 tools/libxl/libxl_cpuid.c  |    2 +-
 tools/libxl/libxl_device.c |    3 +++
 tools/libxl/libxl_dom.c    |   42 ++++++++++++++---------------
 tools/libxl/libxl_pci.c    |    9 +++----
 tools/libxl/libxl_x86.c    |    2 +-
 6 files changed, 59 insertions(+), 63 deletions(-)
Signature · 1 line
1.7.10.4