Skip to content

wireless: address REGULATORY_CUSTOM_REG usage with regulatory_hint()

Luis R. Rodriguez linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ath: fix warning on usage of REGULATORY_CUSTOM_REGdrivers/net/wireless/ath/regd.c+6 -32 replies
2/2cfg80211: make regulatory_hint() remove REGULATORY_CUSTOM_REGdrivers/net/wireless/ath/regd.c include/net/regulatory.h net/wireless/reg.c+6 -22 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFT 0/2] wireless: address REGULATORY_CUSTOM_REG usage with regulatory_hint()

Sujith spotted a warning on the ath module when it doesn't set the REGULATORY_CUSTOM_REG flag but still uses the wiphy_apply_custom_regulatory(). The issue is that the cards that it is warning on are not world roaming but the ath module preference is to be conservative and to apply a custom world roaming regulatory domain *prior* to applying the one seen mandated by the alpha2 on the card with regulatory_hint().

Fix this first in the shared ath module for the Atheros drivers and then later merge a generic solution so that others drivers don't have to do this, and remove the temporary flag removal within the ath module then.

The split of the patches should let John take in the ath module fix while Johannes can take in the generic solution for cfg80211 separately. Once Johannes sends a pull request to Linville I suspect there will be no conflicts.

Sujith please test each one separately if you can.

Luis R. Rodriguez (2):
ath: fix warning on usage of REGULATORY_CUSTOM_REG
cfg80211: make regulatory_hint() remove REGULATORY_CUSTOM_REG

 drivers/net/wireless/ath/regd.c | 7 ++++---
 include/net/regulatory.h        | 4 ++++
 net/wireless/reg.c              | 2 ++
 3 files changed, 10 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.4.3