Skip to content

perf trace fixes

David Ahern lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf trace: Add support for syscalls vs raw_syscallstools/perf/builtin-trace.c+26 -20 replies
2/4perf trace: Fix crash on RHEL6tools/perf/builtin-trace.c+1 -13 replies
3/4perf trace: Fix summary percentage when processing filestools/perf/builtin-trace.c+3 -10 replies
4/4perf trace: Add option to specify machine typetools/perf/builtin-trace.c+14 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] perf trace fixes

Hi Arnaldo:

As I mentioned on IRC perf-trace fails on older kernels -- like RHEL6. This set of patches makes it at least usable - though still some problems I am hoping you can fix.

Build perf with these patches and run:

perf trace -- dd if=/dev/zero of=/tmp/zero bs=4096 count=16

you see something like this which is just wrong:

3.684 ( 0.007 ms): write(buf: 2, count: 140737077958816 ) = 27

there is no fd (should be 1 for the write) and all the values are wrong. Perhaps it is an artifact of the older way of doing system call tracing, but I see something goofy with the 3.12 kernel as well:
5.633 ( 0.004 ms): write(fd: 2, buf: 0x7fff9177fee0, count: 24 ) = 24

According to strace that should be a return of 4096.

David Ahern (4):
perf trace: Add support for syscalls vs raw_syscalls perf trace: Fix crash on RHEL6
perf trace: Fix summary percentage when processing files perf trace: Add option to specify machine type

 tools/perf/builtin-trace.c | 48 ++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 44 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.3.4 (Apple Git-47)