Skip to content

tools lib traceevent: Get rid of *die() calls from parse-filter.c

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 33 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14tools lib traceevent: Get rid of malloc_or_die() in show_error()tools/lib/traceevent/parse-filter.c+15 -112 replies
2/14tools lib traceevent: Get rid of die in add_filter_type()tools/lib/traceevent/parse-filter.c+16 -52 replies
3/14tools lib traceevent: Get rid of malloc_or_die() in pevent_filter_alloc()tools/lib/traceevent/parse-filter.c+4 -10 replies
4/14tools lib traceevent: Get rid of malloc_or_die() allocate_arg()tools/lib/traceevent/parse-filter.c+44 -153 replies
5/14tools lib traceevent: Get rid of malloc_or_die() in read_token()tools/lib/traceevent/parse-filter.c+7 -10 replies
6/14tools lib traceevent: Get rid of malloc_or_die() in find_event()tools/lib/traceevent/parse-filter.c+14 -33 replies
7/14tools lib traceevent: Get rid of malloc_or_die() in add_event()tools/lib/traceevent/parse-filter.c+13 -30 replies
8/14tools lib traceevent: Get rid of die() in create_arg_item()tools/lib/traceevent/parse-filter.c+5 -20 replies
9/14tools lib traceevent: Get rid of die() in add_right()tools/lib/traceevent/parse-filter.c+9 -34 replies
10/14tools lib traceevent: Get rid of die() in reparent_op_arg()tools/lib/traceevent/parse-filter.c+58 -330 replies
11/14tools lib traceevent: Get rid of malloc_or_die() in pevent_filter_add_filter_str()tools/lib/traceevent/parse-filter.c+7 -10 replies
12/14tools lib traceevent: Get rid of die() in pevent_filter_clear_trivial()tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c+16 -70 replies
13/14tools lib traceevent: Refactor test_filter() to get rid of die()tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c+65 -382 replies
14/14tools lib traceevent: Get rid of die() in some string conversion funcitonstools/lib/traceevent/parse-filter.c+31 -202 replies

Reviews trailers per patch

None of the 14 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSteven Rostedt
SeriesR-b
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 00/14] tools lib traceevent: Get rid of *die() calls from parse-filter.c

Hello,

This patchset tries to remove all die() calls in event filter parsing code. The only remaining bits are in trace-seq.c which implement print functions and I want to hear what's the best way we can handle the error case during the print.

I also put this patches on libtraceevent/die-removal-v1 branch in my tree

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks
Namhyung

Namhyung Kim (14):
tools lib traceevent: Get rid of malloc_or_die() in show_error() tools lib traceevent: Get rid of die in add_filter_type() tools lib traceevent: Get rid of malloc_or_die() in
pevent_filter_alloc()
tools lib traceevent: Get rid of malloc_or_die() allocate_arg() tools lib traceevent: Get rid of malloc_or_die() in read_token() tools lib traceevent: Get rid of malloc_or_die() in find_event() tools lib traceevent: Get rid of malloc_or_die() in add_event() tools lib traceevent: Get rid of die() in create_arg_item() tools lib traceevent: Get rid of die() in add_right() tools lib traceevent: Get rid of die() in reparent_op_arg() tools lib traceevent: Get rid of malloc_or_die() in
pevent_filter_add_filter_str()
tools lib traceevent: Get rid of die() in
pevent_filter_clear_trivial()
tools lib traceevent: Refactor test_filter() to get rid of die() tools lib traceevent: Get rid of die() in some string conversion
funcitons

 tools/lib/traceevent/event-parse.h  |   3 +-
 tools/lib/traceevent/parse-filter.c | 432 +++++++++++++++++++++++++-----------
 2 files changed, 303 insertions(+), 132 deletions(-)
Signature · 1 line
1.7.11.7