Skip to content

tracing/uprobes: Add support for more fetch methods (v8)

Namhyung Kim lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17tracing/uprobes: Fix documentation of uprobe registration syntaxDocumentation/trace/uprobetracer.txt kernel/trace/trace_uprobe.c+6 -60 replies
2/17tracing/probes: Fix basic print type functionskernel/trace/trace_probe.c+11 -110 replies
3/17tracing/kprobes: Factor out struct trace_probekernel/trace/trace_kprobe.c kernel/trace/trace_probe.h+289 -2790 replies
4/17tracing/uprobes: Convert to struct trace_probekernel/trace/trace_uprobe.c+79 -800 replies
5/17tracing/kprobes: Move common functions to trace_probe.hkernel/trace/trace_kprobe.c kernel/trace/trace_probe.h+48 -480 replies
6/17tracing/probes: Integrate duplicate set_print_fmt()kernel/trace/trace_kprobe.c kernel/trace/trace_probe.c kernel/trace/trace_probe.h +1 more+66 -1160 replies
7/17tracing/probes: Move fetch function helpers to trace_probe.hkernel/trace/trace_probe.c kernel/trace/trace_probe.h+77 -611 reply
8/17tracing/probes: Split [ku]probes_fetch_type_tablekernel/trace/trace_kprobe.c kernel/trace/trace_probe.c kernel/trace/trace_probe.h +1 more+126 -504 replies
9/17tracing/probes: Implement 'stack' fetch method for uprobeskernel/trace/trace_kprobe.c kernel/trace/trace_probe.c kernel/trace/trace_probe.h +1 more+66 -260 replies
10/17tracing/probes: Move 'symbol' fetch method to kprobeskernel/trace/trace_kprobe.c kernel/trace/trace_probe.c kernel/trace/trace_probe.h +1 more+91 -593 replies
11/17tracing/probes: Add fetch{,_size} member into deref fetch methodkernel/trace/trace_probe.c+20 -20 replies
12/17tracing/probes: Implement 'memory' fetch method for uprobeskernel/trace/trace_kprobe.c kernel/trace/trace_probe.c kernel/trace/trace_probe.h +1 more+130 -823 replies
13/17tracing/uprobes: Pass 'is_return' to traceprobe_parse_probe_arg()kernel/trace/trace_uprobe.c+1 -11 reply
14/17tracing/uprobes: Fetch args before reserving a ring bufferkernel/trace/trace_uprobe.c+132 -140 replies
15/17tracing/uprobes: Add support for full argument access methodsDocumentation/trace/uprobetracer.txt kernel/trace/trace_probe.c+47 -120 replies
16/17uprobes: Allocate ->utask before handler_chain() for tracing handlerskernel/events/uprobes.c+4 -09 replies
17/17tracing/uprobes: Add @+file_offset fetch methodDocumentation/trace/uprobetracer.txt kernel/trace/trace_kprobe.c kernel/trace/trace_probe.c +2 more+63 -10 replies

Reviews trailers per patch

14 of 17 patches have a Reviewed-by or Acked-by.

PatchMasami HiramatsuOleg NesterovSrikar DronamrajuHyeoncheol Lee
1/17R-b A-b A-b
2/17A-b
3/17A-b
4/17R-b A-b
5/17A-b
6/17A-b
7/17A-b
8/17A-b
9/17
10/17
11/17A-b
12/17
13/17R-b
14/17R-b
15/17A-b Original-patch-by
16/17A-b
17/17A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCHSET 00/17] tracing/uprobes: Add support for more fetch methods (v8)

Hello,

This patchset implements memory (address), stack[N], deference, bitfield, retval (it needs uretprobe tho) and file_offset fetch methods for uprobes. It's based on the previous work [1] done by Hyeoncheol Lee.

Now kprobes and uprobes have their own fetch_type_tables and, in turn, memory and stack access methods. The symbol and file_offset fetch methods are only available to kprobes and uprobes, respectively. Other fetch methods are shared.

For the file_offset method, it translates the offset argument to a virtual address in a process. To do that, it calculates base mapping address using probe address (utask->vaddr) and probe offset (tu->offset) and then adds the argument offset. Those info are carried via utask and a new fetch parameter.

The syntax is '@+offset' where offset are relative address to the base address. For shared libraries, it'd be simply the st_value of symbol in ELF format. But for executable, it needs to subtract base load address (e.g. 0x40000 for x86_64) from the symbol value. Please see previous discussion for an example [2] - Note that the syntax changed to '@+' from plain '@'. The plain '@addr' syntax is used for accessing absolute memory address if you already know the exact address.

Many thanks to Oleg who provides valuable feedbacks and suggestions.

The patch 1-2 are bug fixes and can be applied independently. The patch 16 is a preparation for patch 17 which implements the file_offset fetch method.

* v8 changes:
- rename tk, tu and tp more consistently (Srikar)
- change prefix format specifier: %#x -> 0x%x (Masami)
- convert file_offset_param to uprobe_dispatch_data (Oleg)
- add more Ack's from Srikar and Masami

* v7 changes:
- restructure patches not to break build with !CONFIG_[KU]PROBE_EVENT
- print 0x prefix for unsigned types
- add @+file_offset fetch method (Oleg)
- get rid of uprobe_buffer_mutex (Oleg)
- pass 'is_return' to uprobes argument parser

[1] https://lkml.org/lkml/2012/11/14/84
[2] https://lkml.org/lkml/2013/11/5/25

A simple example:

  # cat foo.c
  int glob = -1;
  char str[] = "hello uprobe.";
  struct foo {
    unsigned int unused: 2;
    unsigned int foo: 20;
    unsigned int bar: 10;
  } foo = {
    .foo = 5,
  };

  int main(int argc, char *argv[])
  {
    long local = 0x1234;
    return 127;

}

  # gcc -o foo -g foo.c
  # objdump -d foo | grep -A9 -F '<main>'
  00000000004004b0 <main>:
    4004b0:	55                   	push   %rbp
    4004b1:	48 89 e5             	mov    %rsp,%rbp
    4004b4:	89 7d ec             	mov    %edi,-0x14(%rbp)
    4004b7:	48 89 75 e0          	mov    %rsi,-0x20(%rbp)
    4004bb:	48 c7 45 f8 34 12 00 	movq   $0x1234,-0x8(%rbp)
    4004c2:	00 
    4004c3:	b8 7f 00 00 00       	mov    $0x7f,%eax
    4004c8:	5d                   	pop    %rbp
    4004c9:	c3                   	retq   
  # nm foo | grep -e glob$ -e str -e foo
  00000000006008bc D foo
  00000000006008a8 D glob
  00000000006008ac D str
  # perf probe -x /home/namhyung/tmp/foo -a 'foo=main+0x13 glob=@0x6008a8:s32 \
Quoted 1 line

str=@+0x2008ac:string bit=@+0x2008bc:b10@2/32 argc=%di:s32 local=-0x8(%bp)'

Added new event:

    probe_foo:foo      (on 0x4c3 with glob=@0x6008a8:s32 str=@+0x2008ac:string 
                           bit=@+0x2008bc:b10@2/32 argc=%di:s32 local=-0x8(%bp))

You can now use it in all perf tools, such as:

perf record -e probe_foo:foo -aR sleep 1

  # perf record -e probe_foo:foo ./foo
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.001 MB perf.data (~33 samples) ]
  # perf script | grep -v ^#
               foo  2008 [002  2199.867154: probe_foo:foo (4004c3)
                   glob=-1 str="hello uprobe." bit=0x5 argc=1 local=0x1234

This patchset is based on the current for-next branch of the Steven Rostedt's linux-trace tree. I also put this on my 'uprobe/fetch-v8' branch in my tree:

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Any comments are welcome, thanks.
Namhyung

Cc Masami Hiramatsu <[email protected]>
Cc Srikar Dronamraju <[email protected]>
Cc Oleg Nesterov <[email protected]>
Cc zhangwei(Jovi) <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Hemant Kumar <[email protected]>

Hyeoncheol Lee (1):
tracing/probes: Add fetch{,_size} member into deref fetch method

Namhyung Kim (15):
tracing/uprobes: Fix documentation of uprobe registration syntax tracing/probes: Fix basic print type functions tracing/kprobes: Factor out struct trace_probe tracing/uprobes: Convert to struct trace_probe tracing/kprobes: Move common functions to trace_probe.h tracing/probes: Integrate duplicate set_print_fmt() tracing/probes: Move fetch function helpers to trace_probe.h tracing/probes: Split [ku]probes_fetch_type_table tracing/probes: Implement 'stack' fetch method for uprobes tracing/probes: Move 'symbol' fetch method to kprobes tracing/probes: Implement 'memory' fetch method for uprobes tracing/uprobes: Pass 'is_return' to traceprobe_parse_probe_arg() tracing/uprobes: Fetch args before reserving a ring buffer tracing/uprobes: Add support for full argument access methods tracing/uprobes: Add @+file_offset fetch method

Oleg Nesterov (1):
uprobes: Allocate ->utask before handler_chain() for tracing handlers

 Documentation/trace/uprobetracer.txt |  36 +-
 kernel/events/uprobes.c              |   4 +
 kernel/trace/trace_kprobe.c          | 666 +++++++++++++++++++----------------
 kernel/trace/trace_probe.c           | 458 ++++++++++--------------
 kernel/trace/trace_probe.h           | 220 +++++++++++-
 kernel/trace/trace_uprobe.c          | 481 ++++++++++++++++++-------
 6 files changed, 1140 insertions(+), 725 deletions(-)
Signature · 1 line
1.7.11.7